From owner-cvs-all@FreeBSD.ORG Thu Apr 15 16:53:08 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9AB461065686; Thu, 15 Apr 2010 16:53:08 +0000 (UTC) (envelope-from mohacsi@niif.hu) Received: from mail.ki.iif.hu (mail.ki.iif.hu [IPv6:2001:738:0:411::241]) by mx1.freebsd.org (Postfix) with ESMTP id 4A2818FC22; Thu, 15 Apr 2010 16:53:08 +0000 (UTC) Received: from localhost (localhost [IPv6:::1]) by mail.ki.iif.hu (Postfix) with ESMTP id 521E786D1C; Thu, 15 Apr 2010 18:53:07 +0200 (CEST) X-Virus-Scanned: by amavisd-new at mignon.ki.iif.hu Received: from mail.ki.iif.hu ([127.0.0.1]) by localhost (mignon.ki.iif.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Da0aq5cstpPs; Thu, 15 Apr 2010 18:53:04 +0200 (CEST) Received: by mail.ki.iif.hu (Postfix, from userid 9002) id 3DF4B86D15; Thu, 15 Apr 2010 18:53:04 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.ki.iif.hu (Postfix) with ESMTP id 3C44186CBD; Thu, 15 Apr 2010 18:53:04 +0200 (CEST) Date: Thu, 15 Apr 2010 18:53:04 +0200 (CEST) From: Mohacsi Janos X-X-Sender: mohacsi@mignon.ki.iif.hu To: Doug Barton In-Reply-To: Message-ID: References: <201003312058.o2VKwQfV022077@repoman.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Pav Lucistnik , geoffroy desvernay , cvs-ports@FreeBSD.org, janos.mohacsi@bsd.hu Subject: Re: cvs commit: ports/net-mgmt/nfsen Makefile ports/net-mgmt/nfsen/files nfsen.in nfsen.sh.in patch-libexec_NfSenRRD.pm X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2010 16:53:08 -0000 Approved to change all occurences of /usr/local to %%PREFIX%%. On Wed, 31 Mar 2010, Doug Barton wrote: > So first off, thanks to geoffroy for taking the time to do this. It's nice to > have more of our ports scripts actually making use of the rc.d framework. > > There are however a couple of problems with the script. The most serious is > that all of the examples of "/usr/local" need to be changed to %%PREFIX%% so > that if a user has a different prefix set it will still work. There are other > elements it would be nice to improve, please see > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html > for more information. > > To the maintainer, can you please approve at least the change to %%PREFIX%% > so that we can fix that ASAP? > > > Thanks, > > Doug > > > On Wed, 31 Mar 2010, Pav Lucistnik wrote: > >> pav 2010-03-31 20:58:26 UTC >> >> FreeBSD ports repository >> >> Modified files: >> net-mgmt/nfsen Makefile >> Added files: >> net-mgmt/nfsen/files nfsen.in patch-libexec_NfSenRRD.pm >> Removed files: >> net-mgmt/nfsen/files nfsen.sh.in >> Log: >> - Provide rc.subr script >> >> PR: ports/144384 >> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144384 >> Submitted by: geoffroy desvernay >> Approved by: maintainer >> >> - Allow to work with rrdtool 1.4.x >> >> PR: ports/144876 >> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144876 >> Submitted by: Vincent Hoffman >> Approved by: maintainer >> >> Revision Changes Path >> 1.16 +3 -1 ports/net-mgmt/nfsen/Makefile >> 1.1 +24 -0 ports/net-mgmt/nfsen/files/nfsen.in (new) >> 1.3 +0 -86 ports/net-mgmt/nfsen/files/nfsen.sh.in (dead) >> 1.1 +11 -0 ports/net-mgmt/nfsen/files/patch-libexec_NfSenRRD.pm >> (new) >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/Makefile.diff?&r1=1.15&r2=1.16&f=h >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/files/nfsen.in >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/files/nfsen.sh.in >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/files/patch-libexec_NfSenRRD.pm >> >> > > > -- > > Improve the effectiveness of your Internet presence with > a domain name makeover! http://SupersetSolutions.com/ > > Computers are useless. They can only give you answers. > -- Pablo Picasso > >