From owner-freebsd-current@FreeBSD.ORG Tue Aug 26 10:28:25 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 89B931065687 for ; Tue, 26 Aug 2008 10:28:25 +0000 (UTC) (envelope-from marius@nuenneri.ch) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.181]) by mx1.freebsd.org (Postfix) with ESMTP id 77BA78FC42 for ; Tue, 26 Aug 2008 10:28:25 +0000 (UTC) (envelope-from marius@nuenneri.ch) Received: by wa-out-1112.google.com with SMTP id j4so886669wah.3 for ; Tue, 26 Aug 2008 03:28:24 -0700 (PDT) Received: by 10.115.58.1 with SMTP id l1mr4386278wak.27.1219744960905; Tue, 26 Aug 2008 03:02:40 -0700 (PDT) Received: by 10.115.89.3 with HTTP; Tue, 26 Aug 2008 03:02:40 -0700 (PDT) Message-ID: Date: Tue, 26 Aug 2008 12:02:40 +0200 From: "=?ISO-8859-1?Q?Marius_N=FCnnerich?=" To: "Ed Schouten" In-Reply-To: <20080825141951.GB99951@hoeg.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200808241520.m7OFKiKx018944@svn.freebsd.org> <48B2B7A7.1030907@FreeBSD.org> <20080825141951.GB99951@hoeg.nl> Cc: FreeBSD Current Subject: Re: mouse interactivity (Re: svn commit: r182109 - head/sys/dev/syscons) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2008 10:28:25 -0000 On Mon, Aug 25, 2008 at 4:19 PM, Ed Schouten wrote: > * Kris Kennaway wrote: >> Ed Schouten wrote: >>> Author: ed >>> Date: Sun Aug 24 15:20:44 2008 >>> New Revision: 182109 >>> URL: http://svn.freebsd.org/changeset/base/182109 >>> >>> Log: >>> Make sysmouse(4) use its own locks, instead of using Giant. >>> When I changed syscons(4) to work with the MPSAFE TTY code, I just >>> locked all device nodes down using the compatibility feature that allows >>> you to override the TTY's lock (Giant in this case). Upon closer >>> inspection, it seems sysmouse(4) only has two internal variables that >>> need locking: mouse_level and mouse_status. >>> I haven't done any performance benchmarks on this, though I think >>> it >>> won't have any dramatic improvements on the system. It is good to get >>> rid of Giant here, because the third argument of tty_alloc() has only >>> been added to ease migration to MPSAFE TTY. It should not be used when >>> not needed. >>> While there, remove SC_MOUSE, which is a leftover from the MPSAFE >>> TTY >>> import. >> >> This might help mouse interactivity for desktop users that have legacy >> Giant-locked systems in use (e.g. busy MSDOS filesystems, giant-locked >> disk drivers), etc. > > Yes, but only a very very little bit. moused still delivers the input to > /dev/consolectl, which is still Giant locked. The part where the Xorg > server reads from /dev/sysmouse is now Giant-free. Are you going to lock that one too? I have some problems with a sluggish PS/2 mouse when Firefox runs a heavily javascripted site (though it is way better now that I can use nvidia(4) again without crashing).