From owner-svn-src-all@FreeBSD.ORG Tue Oct 11 15:45:25 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCED31065674; Tue, 11 Oct 2011 15:45:25 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6B7B88FC13; Tue, 11 Oct 2011 15:45:25 +0000 (UTC) Received: by qadz30 with SMTP id z30so6432844qad.13 for ; Tue, 11 Oct 2011 08:45:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=8j6t89vB0szUrzbW6ZtCs138gUXSolq9iBDPzkTAztM=; b=EgIc+uH14OE8FMjMPhRlTLEOW8fJH12wSFStrR9QRfN1T56irw9cHYu003q3z/nWCF H8bxYVgWAHAt7XlIpwmxkH+ML15XuI695J2W551V2L4Rb0oaD81DDHBShlIoVDy1LwCY mledY94FaYRVKVUkrZ4S7yLNWEYc5OZFt1DGQ= MIME-Version: 1.0 Received: by 10.224.181.202 with SMTP id bz10mr11228798qab.59.1318347924805; Tue, 11 Oct 2011 08:45:24 -0700 (PDT) Received: by 10.224.74.82 with HTTP; Tue, 11 Oct 2011 08:45:24 -0700 (PDT) In-Reply-To: <201110081247.p98Cl06s063337@svn.freebsd.org> References: <201110081247.p98Cl06s063337@svn.freebsd.org> Date: Tue, 11 Oct 2011 08:45:24 -0700 Message-ID: From: Garrett Cooper To: Dag-Erling Smorgrav Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226157 - head/usr.bin/kdump X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2011 15:45:26 -0000 On Sat, Oct 8, 2011 at 5:47 AM, Dag-Erling Smorgrav wrote= : > Author: des > Date: Sat Oct =A08 12:47:00 2011 > New Revision: 226157 > URL: http://svn.freebsd.org/changeset/base/226157 > > Log: > =A0Bring ioctlname() in line with all the other *name() functions, which > =A0actually print the name (or the numeric value, if they can't figure ou= t > =A0the correct name) instead of just returning a pointer to it. =A0Also, = since > =A0ioctl numbers are not and probably never will be unique, drop support = for > =A0using a switch statement instead of an if/else chain. Hi Des! Seeing that you've committed quite a bit to kdump recently, could you please take a look at http://www.freebsd.org/cgi/query-pr.cgi?pr=3D161478 ? Thanks! -Garrett