From owner-freebsd-standards@FreeBSD.ORG  Fri Jan  7 10:30:09 2011
Return-Path: <owner-freebsd-standards@FreeBSD.ORG>
Delivered-To: freebsd-standards@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F1CFC106564A
	for <freebsd-standards@hub.freebsd.org>;
	Fri,  7 Jan 2011 10:30:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B49888FC15
	for <freebsd-standards@hub.freebsd.org>;
	Fri,  7 Jan 2011 10:30:09 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p07AU9kj013327
	for <freebsd-standards@freefall.freebsd.org>;
	Fri, 7 Jan 2011 10:30:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p07AU9RR013322;
	Fri, 7 Jan 2011 10:30:09 GMT (envelope-from gnats)
Resent-Date: Fri, 7 Jan 2011 10:30:09 GMT
Resent-Message-Id: <201101071030.p07AU9RR013322@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-standards@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Henning Petersen <henning.petersen@t-online.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E813C106564A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri,  7 Jan 2011 10:29:17 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D832A8FC15
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri,  7 Jan 2011 10:29:17 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p07ATH28037619
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 7 Jan 2011 10:29:17 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p07ATHTc037618;
	Fri, 7 Jan 2011 10:29:17 GMT (envelope-from nobody)
Message-Id: <201101071029.p07ATHTc037618@red.freebsd.org>
Date: Fri, 7 Jan 2011 10:29:17 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: standards/153756: fp leak in hesiod.c .
X-BeenThere: freebsd-standards@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Standards compliance <freebsd-standards.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>, 
	<mailto:freebsd-standards-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-standards>
List-Post: <mailto:freebsd-standards@freebsd.org>
List-Help: <mailto:freebsd-standards-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>, 
	<mailto:freebsd-standards-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jan 2011 10:30:10 -0000


>Number:         153756
>Category:       standards
>Synopsis:       fp leak in hesiod.c .
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-standards
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 07 10:30:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Henning Petersen
>Release:        FreeBSD-current
>Organization:
>Environment:
>Description:
fp leak in hesiod.c .
>How-To-Repeat:

>Fix:
diff -u -r1.9 hesiod.c
--- lib/libc/net/hesiod.c	1 May 2003 19:03:14 -0000	1.9
+++ lib/libc/net/hesiod.c	5 Jan 2011 11:03:35 -0000
@@ -325,6 +325,7 @@
 			*which = strdup(data);
 			if (!*which) {
 				errno = ENOMEM;
+				fclose(fp);
 				return -1;
 			}
 		} else {


Patch attached with submission follows:

diff -u -r1.9 hesiod.c
--- lib/libc/net/hesiod.c	1 May 2003 19:03:14 -0000	1.9
+++ lib/libc/net/hesiod.c	5 Jan 2011 11:03:35 -0000
@@ -325,6 +325,7 @@
 			*which = strdup(data);
 			if (!*which) {
 				errno = ENOMEM;
+				fclose(fp);
 				return -1;
 			}
 		} else {


>Release-Note:
>Audit-Trail:
>Unformatted: