From owner-freebsd-fs@FreeBSD.ORG Sat Jan 24 15:56:43 2004 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B5AFD16A4CE for ; Sat, 24 Jan 2004 15:56:43 -0800 (PST) Received: from mail.codefusionis.com (ns.codefusionis.com [208.33.29.188]) by mx1.FreeBSD.org (Postfix) with SMTP id 44E1B43D31 for ; Sat, 24 Jan 2004 15:56:42 -0800 (PST) (envelope-from tedu@zeitbombe.org) Received: (qmail 16076 invoked by uid 1049); 24 Jan 2004 23:57:04 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 24 Jan 2004 23:57:04 -0000 Date: Sat, 24 Jan 2004 18:57:04 -0500 (EST) From: Ted Unangst X-X-Sender: tedu@ns.codefusionis.com To: freebsd-fs@freebsd.org Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: bug in ffs_vget/ufs_reclaim X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jan 2004 23:56:43 -0000 in ffs_vget, there is a VREF(i_devvp) call a ways into the function. before this happens, there are several vput(vp) calls for various errors. ufs_reclaim() will call vrele(i_devvp), but maybe it was never VREF'd, meaning there will be a mismatch, eventually leading to a panic when the ref goes below zero. is this correct? -- we owe so much money we're not broke we're broken we're so poor we can't even pay attention