From owner-svn-src-all@freebsd.org Mon Sep 19 17:34:56 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B14BBE189C for ; Mon, 19 Sep 2016 17:34:56 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yw0-x232.google.com (mail-yw0-x232.google.com [IPv6:2607:f8b0:4002:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F3ED089E for ; Mon, 19 Sep 2016 17:34:55 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yw0-x232.google.com with SMTP id i129so160005694ywb.0 for ; Mon, 19 Sep 2016 10:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5F3IRW/G7pi7lsOpx2w1EPjGkSn5dirJsPs1AHTwThE=; b=STTORNJS6LiNuM/BRoylTUI5i2/KEZTxcbyWnEPEa2fgFKp8ZORIfA/466mt06lqR3 D6UJkDFyNNKkjwDnV1ey9XNV/dMPMr6oX3ty77TR7W+mhKFExGwnk6hOSJrsTx5H4qB6 TTx5UKpnTLeZVATCeP6BiZY7smi/DjKCDlrh2zrvZmTgBHDVFfq8ecwZFicKhjx8T65I xXxC01Y5z6LH2Ldz6x36c8VKOd7c7FlhTFF6Y74g4FC9y/Y+OrERozf5Y7Ln7X57cUns VNhlU5xDf0n4HulS+i7XtARCb1QCLjNkVExrxqM9moyRtDJRcbduTZzzejcBtPebLyen 4KkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5F3IRW/G7pi7lsOpx2w1EPjGkSn5dirJsPs1AHTwThE=; b=VYDkdvemHii5AJM96gFPCaw6ZQEpXdH8YmA8dPrWmrdZQbfj1ZCJSU6jR6pSDavnWs Nou/quUCDY147oF6GldzA/pf3dbXdGvBE1P1dQEwj9Bx0anX9NthbvD4tQFT/La/AozY TQpZdjjvjZXLwCqqdzbVgnYy/YQGub9x4Oq5L5hyAjaAuWJDaSxdq0W/nt+KioYRdt1J XTVq2+5xp6CUgdYmj1qWXxaB/smQDCt2k48cyhAFOnYyosXZCYSBo8dbOpxKcyAQHvA8 JJFl1Lp9qEKBXFQt5yFtGtW2L7kOfgqD4w/e1hE8+cSVdJvdOQNfBuKYEKsLBABgxCIA s5Pw== X-Gm-Message-State: AE9vXwMjJY4DjD8z6+tGiEcwALaUG7lF9uM6zVQfaqX0bk2AzVMFMPLgsHRIkwCG8XQhbutQfjKHdC6fYsywtA== X-Received: by 10.129.39.83 with SMTP id n80mr25062602ywn.294.1474306494595; Mon, 19 Sep 2016 10:34:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.201.71 with HTTP; Mon, 19 Sep 2016 10:34:54 -0700 (PDT) In-Reply-To: <2159167.HKd1T6hK90@ralph.baldwin.cx> References: <201609182047.u8IKlt4J096682@repo.freebsd.org> <2159167.HKd1T6hK90@ralph.baldwin.cx> From: Ed Schouten Date: Mon, 19 Sep 2016 19:34:54 +0200 Message-ID: Subject: Re: svn commit: r305952 - head/lib/libc/gen To: John Baldwin Cc: Ed Schouten , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 17:34:56 -0000 2016-09-19 18:06 GMT+02:00 John Baldwin : > Don't you need the _Generic hack we have for basename now? The _Generic() hack that we have in place is for dirname() right now. I'll extend it to also cover basename() when replacing that function as well. While we're on the subject, anyone willing to review this change? :-) https://reviews.freebsd.org/D7844 -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717