From owner-cvs-src@FreeBSD.ORG Thu Aug 14 13:27:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B94B37B401 for ; Thu, 14 Aug 2003 13:27:18 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id ECF0243F93 for ; Thu, 14 Aug 2003 13:27:16 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 94027 invoked by uid 1000); 14 Aug 2003 20:27:18 -0000 Date: Thu, 14 Aug 2003 13:27:18 -0700 (PDT) From: Nate Lawson To: Lukas Ertl In-Reply-To: <20030814220900.D744@leelou.in.tern> Message-ID: <20030814132424.N93994@root.org> References: <20030814184108.AE45F37B49A@hub.freebsd.org> <20030814125213.X93797@root.org> <20030814220900.D744@leelou.in.tern> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Robert Watson cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/growfs debug.c debug.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2003 20:27:18 -0000 On Thu, 14 Aug 2003, Lukas Ertl wrote: > On Thu, 14 Aug 2003, Nate Lawson wrote: > > > On Thu, 14 Aug 2003, Robert Watson wrote: > > > Modified files: > > > sbin/growfs debug.c debug.h > > > Log: > > > Commit 1 of 2 to fix ffsinfo(8) for UFS2. > > > > Nice. I have been working on UFS2 support for growfs so if you have any > > work in that area, let me know. Most of it is sblock-related. > > I wasn't aware that growfs has issues with UFS2. What are the problems? The number one problem is the code sucks. No one is willing to maintain it because of this. The number two problem is that not enough testing has been done with growfs on UFS2. Feel free to do this and report any problems. The actual problem I am addressing is larger than growfs. Basically, any time a sblock change is made, every UFS utility in the system has to be updated and growfs has not kept up. So I have extracted sblock updating into a routine that is shared between the kernel and userland so that it's only in one place in the code. But more work is needed before it can be committed. -Nate