From owner-freebsd-ports@FreeBSD.ORG Sat Dec 17 19:05:40 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 681EC106566B; Sat, 17 Dec 2011 19:05:40 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 225618FC0A; Sat, 17 Dec 2011 19:05:39 +0000 (UTC) Received: by iadj38 with SMTP id j38so3246444iad.13 for ; Sat, 17 Dec 2011 11:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=LGqRHoPqcX82RmceHxFfANb9kGq8c0uBNbnFnxQDjIU=; b=Rp1lR4nFQrzt4jtdEzOBP3MKeZMqqHVoW/gr6yomLyvviqu4/9oxOY97Bkdaj1onmR pCUHDUp97Q3H3Z5YFu19Ac4Rb/SiEH5mhOcxJVgmy6sZgoRuOxwmX3M85/pSzEK/z2qb n0o/XzyM+5NeX7PhRIyLSL2ZR72L9EYPGEP4c= Received: by 10.50.158.227 with SMTP id wx3mr17045156igb.52.1324148739283; Sat, 17 Dec 2011 11:05:39 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.199.18 with HTTP; Sat, 17 Dec 2011 11:05:08 -0800 (PST) In-Reply-To: <1RbzOV-000AQU-65@internal.tormail.net> References: <1RbxBi-0008Ls-5O@internal.tormail.net> <1RbzOV-000AQU-65@internal.tormail.net> From: Chris Rees Date: Sat, 17 Dec 2011 19:05:08 +0000 X-Google-Sender-Auth: 1uQ6cww5cZh4PmlFqlJb_iI8IKY Message-ID: To: Jan Beich Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Christer Solskogen , freebsd-ports , garga@freebsd.org Subject: Re: Removal of use_gmake breaks lua X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2011 19:05:40 -0000 On 17 December 2011 18:53, Jan Beich wrote: > Chris Rees writes: > >>> Chris Rees writes: >>> >>>>> as seen here: >>>>> http://docs.freebsd.org/cgi/getmsg.cgi?fetch=3D295602+0+/usr/local/ww= w/db/text/2011/cvs-all/20111113.cvs-all >>>> >>>> I don't like the proposed solution; it's less hackish to just use >>>> gmake again; most people have it installed anyway.... >>> >>> A non-hackish solution would involve fixing sys.mk to guard against >>> recursive inclusion of __MAKE_CONF. bsd.port.mk is known to have >>> this when using make(1) for do-build. >>> >>> Not that I mind shoving the issue under the carpet by using gmake. > [...] >> >> Ah now there is a better solution :) > > It breaks non ports builds if the guard is propagated =A0via .MAKEFLAGS. > And one no longer can .if/.ifdef (in make.conf) innards of ports. > >> >> I'll see if we can get it in the tree. > > Nevermind, in case of lang/lua > > =A01/ sys.mk sets CFLAGS=3D from make.conf > =A02/ Makefile adds -fPIC to CFLAGS > =A03/ bsd.port.mk copies CFLAGS to MAKE_ENV > =A04/ sys.mk sets CFLAGS from make.conf again, > =A0 =A0 `=3D' overrides CFLAGS from environment > > A simple make(1) build doesn't export CFLAGS > > # Makefile > all: > =A0 =A0 =A0 =A0@cd foo && $(MAKE) > =A0 =A0 =A0 =A0@cd foo && CFLAGS=3D'$(CFLAGS)' $(MAKE) > > # foo/Makefile > all: > =A0 =A0 =A0 =A0@echo $(CFLAGS) So... can be worked around with using ?=3D in make.conf? If that's the case then no code needs changing :) Chris