Date: Tue, 26 Mar 2019 08:27:01 +0000 (UTC) From: Michael Tuexen <tuexen@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r345525 - head/sys/netinet Message-ID: <201903260827.x2Q8R19h066216@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: tuexen Date: Tue Mar 26 08:27:00 2019 New Revision: 345525 URL: https://svnweb.freebsd.org/changeset/base/345525 Log: Fix a double free of an SCTP association in an error path. This is joint work with rrs@. The issue was found by running syzkaller. MFC after: 1 week Modified: head/sys/netinet/sctp_usrreq.c Modified: head/sys/netinet/sctp_usrreq.c ============================================================================== --- head/sys/netinet/sctp_usrreq.c Tue Mar 26 08:10:51 2019 (r345524) +++ head/sys/netinet/sctp_usrreq.c Tue Mar 26 08:27:00 2019 (r345525) @@ -1481,8 +1481,6 @@ sctp_do_connect_x(struct socket *so, struct sctp_inpcb sctp_connectx_helper_add(stcb, sa, (totaddr - 1), &error); /* Fill in the return id */ if (error) { - (void)sctp_free_assoc(inp, stcb, SCTP_PCBFREE_FORCE, - SCTP_FROM_SCTP_USRREQ + SCTP_LOC_7); goto out_now; } a_id = (sctp_assoc_t *)optval;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903260827.x2Q8R19h066216>