Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Dec 2021 22:40:50 GMT
From:      Piotr Kubaj <pkubaj@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: 0442d884484b - main - multimedia/gstreamer1-plugins-rust: fix build on powerpc
Message-ID:  <202112122240.1BCMeoe3021775@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by pkubaj:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0442d884484bed7824380d9e3d6f8cbf13e59bd7

commit 0442d884484bed7824380d9e3d6f8cbf13e59bd7
Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
AuthorDate: 2021-12-12 22:35:11 +0000
Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
CommitDate: 2021-12-12 22:35:11 +0000

    multimedia/gstreamer1-plugins-rust: fix build on powerpc
    
    Disable CSOUND, same issue as on powerpc64*:
    error[E0433]: failed to resolve: use of undeclared crate or module `imp`
      --> /wrkdirs/usr/ports/multimedia/gstreamer1-plugins-rust/work/gst-plugins-rs-d0466b3eee114207f851b37cae0015c0e718f021/cargo-crates/va_list-0.1.3/src/lib.rs:77:15
       |
    77 |     internal: imp::VaList,
       |               ^^^ use of undeclared crate or module `imp`
    
    error[E0433]: failed to resolve: use of undeclared crate or module `imp`
      --> /wrkdirs/usr/ports/multimedia/gstreamer1-plugins-rust/work/gst-plugins-rs-d0466b3eee114207f851b37cae0015c0e718f021/cargo-crates/va_list-0.1.3/src/lib.rs:93:24
       |
    93 |     unsafe fn get(&mut imp::VaList) -> Self;
       |                        ^^^ use of undeclared crate or module `imp`
    
    warning: anonymous parameters are deprecated and will be removed in the next edition.
      --> /wrkdirs/usr/ports/multimedia/gstreamer1-plugins-rust/work/gst-plugins-rs-d0466b3eee114207f851b37cae0015c0e718f021/cargo-crates/va_list-0.1.3/src/lib.rs:93:19
       |
    93 |     unsafe fn get(&mut imp::VaList) -> Self;
       |                   ^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut imp::VaList`
       |
       = note: `#[warn(anonymous_parameters)]` on by default
       = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018!
       = note: for more information, see issue #41686 <https://github.com/rust-lang/rust/issues/41686>;
    
    For more information about this error, try `rustc --explain E0433`.
    warning: `va_list` (lib) generated 1 warning
    Error: CliError { error: Some(could not compile `va_list` due to 2 previous errors; 1 warning emitted
    
    Also patch crossbeam-utils crate for no atomics on powerpc.
    
    Building dav1d segfaults, so disable it as well:
        process didn't exit successfully: `/wrkdirs/usr/ports/multimedia/gstreamer1-plugins-rust/work/gst-plugins-rs-d0466b3eee114207f851b37cae0015c0e718f021/_build/target/release/build/dav1d-sys-3a3db191566872b8/build-script-build` (signal: 11, SIGSEGV: invalid memory reference)
---
 multimedia/gstreamer1-plugins-rust/Makefile            |  5 +++--
 multimedia/gstreamer1-plugins-rust/files/patch-powerpc | 10 ++++++++++
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/multimedia/gstreamer1-plugins-rust/Makefile b/multimedia/gstreamer1-plugins-rust/Makefile
index 7e611c7a8b9f..4a2468cfb54f 100644
--- a/multimedia/gstreamer1-plugins-rust/Makefile
+++ b/multimedia/gstreamer1-plugins-rust/Makefile
@@ -401,8 +401,9 @@ CARGO_TEST=	no
 OPTIONS_DEFINE=	CSOUND DAV1D PANGO SODIUM
 OPTIONS_DEFAULT=CSOUND DAV1D PANGO SODIUM
 OPTIONS_EXCLUDE_aarch64=	CSOUND # https://github.com/neithanmo/csound-rs/commit/8962b89d7bda
-OPTIONS_EXCLUDE_powerpc64le=	CSOUND # https://github.com/neithanmo/csound-rs/commit/8962b89d7bda
-OPTIONS_EXCLUDE_powerpc64=	CSOUND # https://github.com/neithanmo/csound-rs/commit/8962b89d7bda
+OPTIONS_EXCLUDE_powerpc64le=	CSOUND
+OPTIONS_EXCLUDE_powerpc64=	CSOUND
+OPTIONS_EXCLUDE_powerpc=	CSOUND DAV1D
 OPTIONS_SUB=	yes
 
 CSOUND_DESC=		Audio filtering via Csound
diff --git a/multimedia/gstreamer1-plugins-rust/files/patch-powerpc b/multimedia/gstreamer1-plugins-rust/files/patch-powerpc
new file mode 100644
index 000000000000..b9159f01c024
--- /dev/null
+++ b/multimedia/gstreamer1-plugins-rust/files/patch-powerpc
@@ -0,0 +1,10 @@
+--- cargo-crates/crossbeam-utils-0.8.5/no_atomic.rs.orig	2021-07-12 16:01:05.023177000 +0200
++++ cargo-crates/crossbeam-utils-0.8.5/no_atomic.rs	2021-07-12 16:01:16.538869000 +0200
+@@ -30,6 +30,7 @@
+     "mipsel-unknown-none",
+     "mipsisa32r6-unknown-linux-gnu",
+     "mipsisa32r6el-unknown-linux-gnu",
++    "powerpc-unknown-freebsd",
+     "powerpc-unknown-linux-gnu",
+     "powerpc-unknown-linux-gnuspe",
+     "powerpc-unknown-linux-musl",



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202112122240.1BCMeoe3021775>