From owner-freebsd-current@FreeBSD.ORG Tue Jun 24 14:54:09 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6954637B401 for ; Tue, 24 Jun 2003 14:54:09 -0700 (PDT) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9BDC243FDF for ; Tue, 24 Jun 2003 14:54:08 -0700 (PDT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.12.9/8.12.9) with ESMTP id h5OLs8wV010347 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 24 Jun 2003 17:54:08 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.11.6/8.9.1) id h5OLs2495033; Tue, 24 Jun 2003 17:54:02 -0400 (EDT) (envelope-from gallatin@cs.duke.edu) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16120.51322.899065.483700@grasshopper.cs.duke.edu> Date: Tue, 24 Jun 2003 17:54:02 -0400 (EDT) To: "Alan L. Cox" In-Reply-To: <3EF8ACB5.C8379525@imimic.com> References: <20030624004308.GA17534@rot13.obsecurity.org> <3EF8ACB5.C8379525@imimic.com> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid cc: current@FreeBSD.org Subject: Re: LOR in VM (with backtrace) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2003 21:54:09 -0000 Alan L. Cox writes: > Thanks for letting me know. This is another false positive: Witness > can't distinguish the lock on the object being destroyed from the lock > on the object used by UMA because their labels are the same. They will > never, however, be the same object. So, deadlock isn't a risk. In a closed source driver I maintain, I had to resort to passing a string containing the meaningful name concatonated with some unique info to mtx_init(). It seems like witness could just concat the address of the mutex along with the strings passed to mtx_init() so as to make sure things were unique.. Drew