From nobody Thu Jul 7 15:52:49 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8FB9912D1A31 for ; Thu, 7 Jul 2022 15:53:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lf1CW3Txfz3QBS for ; Thu, 7 Jul 2022 15:53:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vk1-xa2c.google.com with SMTP id j63so3547372vkj.8 for ; Thu, 07 Jul 2022 08:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tNPsYj5S4OMxEZsQhZiEoNLgQ/fu6/rBU0/gwQRYF5c=; b=fAabS88pMbriF9fWeMkjxJf+72TibDwbxaEDKLh8KoDUbOM2BveLa/gpF23vmjQBW1 inF1NNrCUZf8tw2uMFxg4wnMDYHf+f2lCORdHJGjVB2xxxLTtw+RZNeob7DTEBjBAU5G q+jCNJGhwQvzCJ3STE5/5d9SSxqGsOM+u2jSvSCGrT98wbIQ9vPcuAQvyPtEweU4Y2zJ THo1uKA6lyZ2EOArW2PmQZIjFSdXTiAR2+u9mEwFpOCq5/4t3+i+06jh5rZ/RkxlTP9A Xa7W+s3/F/IaaE+4BOUjcSWO8Apfr2NwmFVMYfb6PVUeQMYN7YgBtU+iNzjE83fPsVzB g8kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tNPsYj5S4OMxEZsQhZiEoNLgQ/fu6/rBU0/gwQRYF5c=; b=eQB1m/QEi+ggCzYjaJ1G6aqR29V4nEHySbZwVGoHU4Kf38hu2B50dVC6+i+eoowAOy peABRqzWJQwOG792Acm5IHdZ57bxHNhgQrSOZHohLeMfE3KYnQRI6Bl+gxzQ6lScW5MQ aBfu03A7IWZ+B+QEUQ0OP3pbpVScf5TnuylvwQzeZHIDe/TfISCr8j0uIN49lZB2fd3j lLfiXEcs/kVuRBxpXKHQEf4D+IPseKsvSIuvJ+k9eohS7Uy1Bc+aGRvKGw5AV5f7012F Tsogm/WMwYEJhypw3ikxNC+hb0F9bLyIALBVKdNHToM1YR7UY6eeJjgNeWbbj9ETdqgO X/jA== X-Gm-Message-State: AJIora/YgiQ/W/bNZATL487QeF39jotXcj2nAvlgYWYH2hm7+qkdJVL4 vrT8V21qhCzAqqt5x/98tn5R6x6EGlD/jlsyOy10aQ== X-Google-Smtp-Source: AGRyM1vD/lRBQ7m+xvJrNsNycYI4qgIcDllx3sdcAa8qXC49z8BDK911EiPo/ya24Fu9535tCdGfZGeI4tGErF3DLCo= X-Received: by 2002:a1f:1bc8:0:b0:36c:a88c:961a with SMTP id b191-20020a1f1bc8000000b0036ca88c961amr26714765vkb.2.1657209180775; Thu, 07 Jul 2022 08:53:00 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: <20220707152506.55626-1-sebastian.huber@embedded-brains.de> In-Reply-To: <20220707152506.55626-1-sebastian.huber@embedded-brains.de> From: Warner Losh Date: Thu, 7 Jul 2022 09:52:49 -0600 Message-ID: Subject: Re: [PATCH 0/6] Simplify pps_capture() and pps_event() To: Sebastian Huber Cc: FreeBSD Hackers Content-Type: multipart/alternative; boundary="0000000000008c0a1005e33914e9" X-Rspamd-Queue-Id: 4Lf1CW3Txfz3QBS X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=fAabS88p; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::a2c) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-0.92 / 15.00]; NEURAL_HAM_SHORT(-0.92)[-0.919]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-hackers]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::a2c:from]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; FROM_HAS_DN(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; DMARC_NA(0.00)[bsdimp.com]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --0000000000008c0a1005e33914e9 Content-Type: text/plain; charset="UTF-8" You might have better luck getting these patches reviewed with either a pull request against github mentioning the usual time people (phk, etc), or as a series of phabricator reviews adding said people. If unsure, mention/add me and I'll add others :). Hackers is (or has been) a high enough volume list that this may not be noticed by those people, especially since there's not a strong tradition of reviewing patches here. On their surface (without having had time to study them in depth), these seem reasonable improvements. But having some context about why you are making these, and/or measurements you've done to show no harm (or hopefully an improvement) would be even better. This is slightly tricky code that has had about 20 years of "soak time" in some fairly demanding environments, and so some caution is advised in updating it. Warner On Thu, Jul 7, 2022 at 9:27 AM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > This patch set tries to simplify the pps_capture() and pps_event() > processing. > I am not sure if the rounding change is an improvement. > > Sebastian Huber (6): > pps: Load timecounter once in pps_capture() > pps: Simplify capture and event processing > pps: Move pcount assignment in pps_event() > pps: Directly assign the timestamps in pps_event() > pps: Simplify the nsec calculation in pps_event() > pps: Round to closest integer in pps_event() > > sys/kern/kern_tc.c | 72 +++++++++++++++++++++++----------------------- > 1 file changed, 36 insertions(+), 36 deletions(-) > > -- > 2.35.3 > > > --0000000000008c0a1005e33914e9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
You might have better luck getting these patches reviewed = with either a pull request against github
mentioning the usual time peo= ple (phk, etc), or as a series=C2=A0of phabricator reviews adding said peop= le.
If unsure, mention/add me and I'll add others :).

Hackers is (or has been) a high enough volume list that t= his may not be noticed by those people,
especially since there= 9;s not a strong tradition of reviewing patches here.

<= div>On their surface (without having had time to study them in depth), thes= e seem reasonable improvements.
But having some context about why= you are making these, and/or measurements you've done to show no
=
harm (or hopefully an improvement) would be even better. This is sligh= tly tricky code that has had about 20
years of "soak time&qu= ot; in some fairly demanding environments, and so some caution is advised i= n updating
it.

Warner

On Thu, Jul 7= , 2022 at 9:27 AM Sebastian Huber <sebastian.huber@embedded-brains.de> wrote:
This patch set tries to = simplify the pps_capture() and pps_event() processing.
I am not sure if the rounding change is an improvement.

Sebastian Huber (6):
=C2=A0 pps: Load timecounter once in pps_capture()
=C2=A0 pps: Simplify capture and event processing
=C2=A0 pps: Move pcount assignment in pps_event()
=C2=A0 pps: Directly assign the timestamps in pps_event()
=C2=A0 pps: Simplify the nsec calculation in pps_event()
=C2=A0 pps: Round to closest integer in pps_event()

=C2=A0sys/kern/kern_tc.c | 72 +++++++++++++++++++++++----------------------= -
=C2=A01 file changed, 36 insertions(+), 36 deletions(-)

--
2.35.3


--0000000000008c0a1005e33914e9--