Date: Thu, 7 Jul 2022 09:52:49 -0600 From: Warner Losh <imp@bsdimp.com> To: Sebastian Huber <sebastian.huber@embedded-brains.de> Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: [PATCH 0/6] Simplify pps_capture() and pps_event() Message-ID: <CANCZdfru6K7Z-TCvRk3YcSGrU6EWSD8Ottd6vDNhe_2jQEFsrg@mail.gmail.com> In-Reply-To: <20220707152506.55626-1-sebastian.huber@embedded-brains.de> References: <20220707152506.55626-1-sebastian.huber@embedded-brains.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000008c0a1005e33914e9 Content-Type: text/plain; charset="UTF-8" You might have better luck getting these patches reviewed with either a pull request against github mentioning the usual time people (phk, etc), or as a series of phabricator reviews adding said people. If unsure, mention/add me and I'll add others :). Hackers is (or has been) a high enough volume list that this may not be noticed by those people, especially since there's not a strong tradition of reviewing patches here. On their surface (without having had time to study them in depth), these seem reasonable improvements. But having some context about why you are making these, and/or measurements you've done to show no harm (or hopefully an improvement) would be even better. This is slightly tricky code that has had about 20 years of "soak time" in some fairly demanding environments, and so some caution is advised in updating it. Warner On Thu, Jul 7, 2022 at 9:27 AM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > This patch set tries to simplify the pps_capture() and pps_event() > processing. > I am not sure if the rounding change is an improvement. > > Sebastian Huber (6): > pps: Load timecounter once in pps_capture() > pps: Simplify capture and event processing > pps: Move pcount assignment in pps_event() > pps: Directly assign the timestamps in pps_event() > pps: Simplify the nsec calculation in pps_event() > pps: Round to closest integer in pps_event() > > sys/kern/kern_tc.c | 72 +++++++++++++++++++++++----------------------- > 1 file changed, 36 insertions(+), 36 deletions(-) > > -- > 2.35.3 > > > --0000000000008c0a1005e33914e9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">You might have better luck getting these patches reviewed = with either a pull request against github<div>mentioning the usual time peo= ple (phk, etc), or as a series=C2=A0of phabricator reviews adding said peop= le.</div><div>If unsure, mention/add me and I'll add others :).</div><d= iv><br></div><div>Hackers is (or has been) a high enough volume list that t= his may not be noticed by those people,</div><div>especially since there= 9;s not a strong tradition of reviewing patches here.</div><div><br></div><= div>On their surface (without having had time to study them in depth), thes= e seem reasonable improvements.</div><div>But having some context about why= you are making these, and/or measurements you've done to show no</div>= <div>harm (or hopefully an improvement) would be even better. This is sligh= tly tricky code that has had about 20</div><div>years of "soak time&qu= ot; in some fairly demanding environments, and so some caution is advised i= n updating</div><div>it.</div><div><br></div><div>Warner</div></div><br><di= v class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jul 7= , 2022 at 9:27 AM Sebastian Huber <<a href=3D"mailto:sebastian.huber@emb= edded-brains.de">sebastian.huber@embedded-brains.de</a>> wrote:<br></div= ><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border= -left:1px solid rgb(204,204,204);padding-left:1ex">This patch set tries to = simplify the pps_capture() and pps_event() processing.<br> I am not sure if the rounding change is an improvement.<br> <br> Sebastian Huber (6):<br> =C2=A0 pps: Load timecounter once in pps_capture()<br> =C2=A0 pps: Simplify capture and event processing<br> =C2=A0 pps: Move pcount assignment in pps_event()<br> =C2=A0 pps: Directly assign the timestamps in pps_event()<br> =C2=A0 pps: Simplify the nsec calculation in pps_event()<br> =C2=A0 pps: Round to closest integer in pps_event()<br> <br> =C2=A0sys/kern/kern_tc.c | 72 +++++++++++++++++++++++----------------------= -<br> =C2=A01 file changed, 36 insertions(+), 36 deletions(-)<br> <br> -- <br> 2.35.3<br> <br> <br> </blockquote></div> --0000000000008c0a1005e33914e9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfru6K7Z-TCvRk3YcSGrU6EWSD8Ottd6vDNhe_2jQEFsrg>