From nobody Tue Feb 4 19:15:28 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YnY3y63Lfz5mJSH; Tue, 04 Feb 2025 19:15:42 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YnY3y475Cz42n3; Tue, 04 Feb 2025 19:15:42 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5dc82e38c10so9207795a12.3; Tue, 04 Feb 2025 11:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738696540; x=1739301340; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pPCH9UKARa5oE1/0lhS3qryJrfwXwhkKKBEhY+n6u7E=; b=X9aUx38tmkqvlN9ghX/5xs08YqwJVqt454/liqn+tpZVzAHwqDx8T4VugLRobTOoeQ Y5FusoPDJNxlKvx0f2tRV+h/aedU8n7cLayuoxbOMWbI2zTVSUDqeX7+g5jnIw4Cryck yvkiL8fv0IrGkn9/WFGAyE95o0ftOeH/gEDsNHR2PO28Kd6wjnRz+c0TdAtl+dMWNesq aswQaEF3O/84M0krHlIwsGkj/13un7E25EELzMsuVTiHNKk1FcCzQUaMIcOJ/4X1sSpj DZTPcdZhOPeXFFGLRyKJSioSdkV0AjsUvyI7WHl6bAYR3r9PQ9IsyGnyQarelt/7uN22 jnVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738696540; x=1739301340; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pPCH9UKARa5oE1/0lhS3qryJrfwXwhkKKBEhY+n6u7E=; b=JYcYzsAJBFoB45i6gZMmOrZ+1nsu7qp62PUTUGn6FNSQthcpiPOVBXK96CCDd8SotY yf6ZYvlAnVFFQk1pcLO/JX/Tj8PJ/E4oU2EIf3s+A4OBrnfi+uTw09GGiYub6QYxvTtz 0q1gTG1Ezt4o/k1dTWKpv3/XRdq0YB7sriy/ZbwIylGndnC+u6mdoMVnB4bQFArYxFWr XhVPvQ9i7P0pBcACop5bV/6nqGhpy9QxotQs/4JIJnSSqIInYd28dcCu0L20GP0q05Wd q/8tXLciwI2n6YjnqSRFO1/bYWKfVaU01UNndCyCwcEDC6tVVer5mFYe5+OqvVfzO/IV fEaA== X-Forwarded-Encrypted: i=1; AJvYcCUppcc4vyGfNprfGuos3rLCvdan0rnCxQd6O3fnl/usUmTewPwnuPe9/xMdHB4NSPpRkf8FSzpjPrp3rIVuykYE4v72@freebsd.org, AJvYcCVBXVUQcLmGIj2tnxBCLLzUNq+/EQMCdS6H5DSujeYf6o7vOt3p0SUmrVYuRIgYcuIoRZwqz/BikXvPOi3Grm6hbbIJPfY=@freebsd.org, AJvYcCXsdShbG4TT8hAjtCd7h56h0eW9jud79qMGuw4XYg3ygGe6p+2Bo0GA3s9vzz996IC+YYKLg3mTgOcGdkXlN1w=@freebsd.org X-Gm-Message-State: AOJu0YykSsCHqzDH2G4Mn6cCfNVeLRvL/Ky7v4dZq6hQsnsCZQ0prfT6 7SQSp9yAd+Z+VHF9RpjbzaQoafynYBiXCWPRDX5WIJoiNgl8wVRifvQ9h+EhusOBX9gGR+gJrQj K1wfV6p7+sb8EFhLJLXATBlzD8g== X-Gm-Gg: ASbGnct6e+TQGB3pFwrXHAUiNeTREiho/eF/CvSWB3at9xi/4tujZLDMKiSfzvgOKAs e9dDZ7z7kK4PRpof+z/D9qDy2cVF9j96ab7CC4/1CTcCZIBzjK9vgBJI+5i7/jz282blo6Vfh/J TMa+Fn1BNZggi2oIYADNCHpbA4Nlzd X-Google-Smtp-Source: AGHT+IFkmN2it0Xm/TxvZ9Wli8stOQB4Z+8hpFmPWiBFPKrB7ahRjpV+r7/ORbDqcK+u4xpOQ9ay3Qed19q+oCT17OQ= X-Received: by 2002:a05:6402:5419:b0:5dc:d43c:3a1b with SMTP id 4fb4d7f45d1cf-5dcdb764622mr187901a12.20.1738696539692; Tue, 04 Feb 2025 11:15:39 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202502041658.514Gwo4I049201@gitrepo.freebsd.org> <20250204171121.8EA2C281@slippy.cwsent.com> In-Reply-To: <20250204171121.8EA2C281@slippy.cwsent.com> From: Rick Macklem Date: Tue, 4 Feb 2025 11:15:28 -0800 X-Gm-Features: AWEUYZkbzXSWa1zf-k0Rt76FukXS-lsRquMzLTpCAwRoK4luWg4U1MEc9dfewgQ Message-ID: Subject: Re: git: ecccb638d494 - main - mountd: Promote missing netmask log to LOG_ERR To: Cy Schubert Cc: Ed Maste , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4YnY3y475Cz42n3 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] On Tue, Feb 4, 2025 at 9:21=E2=80=AFAM Cy Schubert wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > > In message <202502041658.514Gwo4I049201@gitrepo.freebsd.org>, Ed Maste > writes: > > The branch main has been updated by emaste: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Decccb638d494f2642f1e2eae= 8ad932ba > > 70567ccc > > > > commit ecccb638d494f2642f1e2eae8ad932ba70567ccc > > Author: Ed Maste > > AuthorDate: 2025-02-01 13:16:47 +0000 > > Commit: Ed Maste > > CommitDate: 2025-02-04 16:58:41 +0000 > > > > mountd: Promote missing netmask log to LOG_ERR > > > > Historical network classes are deprecated, but currently still supp= orted > > in mountd with a LOG_WARNING-priority message added by Mike Karels = in > > 2021. Upgrade the log to LOG_ERR well in advance of this becoming = a > > fatal error. > > > > Reviewed by: rmacklem > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D48795 > > --- > > usr.sbin/mountd/mountd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/usr.sbin/mountd/mountd.c b/usr.sbin/mountd/mountd.c > > index 4457a925c2ed..19d76b72da10 100644 > > --- a/usr.sbin/mountd/mountd.c > > +++ b/usr.sbin/mountd/mountd.c > > @@ -1806,7 +1806,7 @@ get_exportlist_one(int passno) > > len =3D endcp - cp; > > } > > if (opt_flags & OP_CLASSMASK) > > - syslog(LOG_WARNING, > > + syslog(LOG_ERR, > > "WARNING: No mask specified for %s, " > > Should this be changed from WARNING to ERROR too? I don't have a strong opinion, but I would say no. An error in mountd indicates a failure and in this case the semantics remain what they have always been and doesn't necessarily imply a semantics failure. rick > > > "using out-of-date default", > > (&grp->gr_ptr.gt_net)->nt_name); > > > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > e^(i*pi)+1=3D0 > > >