From owner-cvs-all Tue Jul 17 13:30:26 2001 Delivered-To: cvs-all@freebsd.org Received: from sneakerz.org (sneakerz.org [216.33.66.254]) by hub.freebsd.org (Postfix) with ESMTP id B3EED37B401; Tue, 17 Jul 2001 13:30:18 -0700 (PDT) (envelope-from bright@sneakerz.org) Received: by sneakerz.org (Postfix, from userid 1092) id 2AE3E5D010; Tue, 17 Jul 2001 15:30:08 -0500 (CDT) Date: Tue, 17 Jul 2001 15:30:08 -0500 From: Alfred Perlstein To: Kris Kennaway Cc: "Daniel C. Sobral" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_output.c Message-ID: <20010717153008.A28164@sneakerz.org> References: <200107171847.f6HIlmE61224@freefall.freebsd.org> <20010717132140.A80698@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20010717132140.A80698@xor.obsecurity.org>; from kris@obsecurity.org on Tue, Jul 17, 2001 at 01:21:41PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Kris Kennaway [010717 15:21] wrote: > On Tue, Jul 17, 2001 at 11:47:48AM -0700, Daniel C. Sobral wrote: > > dcs 2001/07/17 11:47:48 PDT > > > > Modified files: > > sys/netinet ip_output.c > > Log: > > Skip the route checking in the case of multicast packets with known > > interfaces. > > > > Reviewed by: people at that channel > > Who? That's not an appropriate review line. > > Kris I didn't see anything functionally incorrect about it, however I wasn't sure if the actual behavior was appropriate, it should have been passed by jlemon or archie or I should have had enough time to examine it, or.... it should have had a much more verbose message exlpaining exactly why the change was done. forced commit at least, please? -- -Alfred Perlstein [alfred@freebsd.org] Ok, who wrote this damn function called '??'? And why do my programs keep crashing in it? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message