From owner-cvs-src@FreeBSD.ORG Wed Jul 28 18:23:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F29716A4CE; Wed, 28 Jul 2004 18:23:08 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 608A843D5C; Wed, 28 Jul 2004 18:23:08 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i6SIN8uJ006109; Wed, 28 Jul 2004 18:23:08 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i6SIN8pQ006108; Wed, 28 Jul 2004 18:23:08 GMT (envelope-from alc) Message-Id: <200407281823.i6SIN8pQ006108@repoman.freebsd.org> From: Alan Cox Date: Wed, 28 Jul 2004 18:23:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_object.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2004 18:23:08 -0000 alc 2004-07-28 18:23:08 UTC FreeBSD src repository Modified files: sys/vm vm_object.c Log: Correct a very old error in both vm_object_madvise() (originating in vm/vm_object.c revision 1.88) and vm_object_sync() (originating in vm/vm_map.c revision 1.36): When descending a chain of backing objects, both use the wrong object's backing offset. Consequently, both may operate on the wrong pages. Quoting Matt, "This could be responsible for all of the sporatic madvise oddness that has been reported over the years." Reviewed by: Matt Dillon Revision Changes Path 1.329 +2 -2 src/sys/vm/vm_object.c