From owner-freebsd-acpi@FreeBSD.ORG Tue Feb 12 19:09:16 2008 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 63F3716A474; Tue, 12 Feb 2008 19:09:16 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 8C7DC13C45B; Tue, 12 Feb 2008 19:09:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8s) with ESMTP id 231711055-1834499 for multiple; Tue, 12 Feb 2008 14:09:00 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m1CJ9B3W063998; Tue, 12 Feb 2008 14:09:11 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-acpi@freebsd.org Date: Tue, 12 Feb 2008 10:29:35 -0500 User-Agent: KMail/1.9.7 References: <47B0BCA2.6040204@icyb.net.ua> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802121029.35850.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 12 Feb 2008 14:09:11 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/5789/Tue Feb 12 09:56:33 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.1 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00, DATE_IN_PAST_03_06 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: njl@freebsd.org, Andriy Gapon Subject: Re: probable typo in acpi_cpu.c X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2008 19:09:16 -0000 On Monday 11 February 2008 06:59:19 pm Rui Paulo wrote: > > On Feb 11, 2008, at 9:22 PM, Andriy Gapon wrote: > > > > > There is probably a typo in acpi_cpu.c, function acpi_cpu_startup: > > if (cpu_quirks && CPU_QUIRK_NO_C3) { <----- here > > sc->cpu_cx_count = sc->cpu_non_c3 + 1; > > } > > > > Not sure how that affects the logic though. > > You are right. This means that the C3 state will still be available on > systems like those based on PIIX4. > > Nate, could you please commit a fix for it? I've committed it, but I don't think it has that affect. Instead, CPU_QUIRK_NO_C3 is always true, so it basically boils down to if (cpu_quirks) { /* Disable C3 */ } So I think the result is that C3 is disabled for other quirks (i.e. the NO_BM_CTRL quirk). This includes SMP machines that don't have _CST. -- John Baldwin