From owner-cvs-all@FreeBSD.ORG Sun Sep 3 20:40:58 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 865EE16A4E2; Sun, 3 Sep 2006 20:40:58 +0000 (UTC) (envelope-from brian@FreeBSD.org) Received: from storm.uk.FreeBSD.org (storm.uk.FreeBSD.org [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB49A43D49; Sun, 3 Sep 2006 20:40:57 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from gw.Awfulhak.org (root@gw.lan.Awfulhak.org [172.16.0.1]) by storm.uk.FreeBSD.org (8.13.8/8.13.8) with ESMTP id k83KesmA049110; Sun, 3 Sep 2006 21:40:55 +0100 (BST) (envelope-from brian@FreeBSD.org) Received: from dev.lan.Awfulhak.org (brian@dev.lan.Awfulhak.org [172.16.0.5]) by gw.Awfulhak.org (8.13.6/8.13.6) with ESMTP id k83KeqN3048610; Sun, 3 Sep 2006 13:40:52 -0700 (PDT) (envelope-from brian@FreeBSD.org) Date: Sun, 3 Sep 2006 13:40:51 -0700 From: Brian Somers To: Slawa Olhovchenkov Message-ID: <20060903134051.7c5ece70@dev.lan.Awfulhak.org> In-Reply-To: <20060903184227.GA6453%slw@zxy.spb.ru> References: <200601030917.k039H4pC060911@repoman.freebsd.org> <20060903184227.GA6453%slw@zxy.spb.ru> X-Mailer: Sylpheed-Claws 2.4.0 (GTK+ 2.8.20; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=5.0 tests=ALL_TRUSTED,SPF_SOFTFAIL autolearn=failed version=3.1.4 X-Spam-Checker-Version: SpamAssassin 3.1.4 (2006-07-25) on gw.lan.Awfulhak.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Sep 2006 20:40:58 -0000 On Sun, 3 Sep 2006 22:42:27 +0400 Slawa Olhovchenkov wrote: > On Tue, Jan 03, 2006 at 09:17:04AM +0000, Brian Somers wrote: > > > brian 2006-01-03 09:17:04 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/su su.c > > Log: > > Fix the other su bug reintroduced two commits ago, namely > > > > $ su > > % kill -STOP $$ > > > > where su is executing (t)csh. csh's job handling is a little more > > special than that of (a)sh, bash and even zsh and blows up a little > > more spectacularly. This modification restores the original mucking > > about with the tty pgrp, but is careful to only do it when su (or > > su's child) is the foreground process. > > > > While I'm here, fix a STDERR_FILENO spelling as suggested by bde. > > This is break 'make config' in ports tree: > > > make config > ===> Switching to root credentials to create /var/db/ports/glib20 > ===> Returning to user credentials > > Suspended (tty output) > > For sh, tcsh and other shell. > > > Revision Changes Path > > 1.79 +14 -1 src/usr.bin/su/su.c Interesting... If I "make -dl config" in devel/glib20, I see it's running this: (/usr/bin/su root -c "/bin/sh -c \"/bin/mkdir -p `/usr/bin/dirname /var/db/ports/glib20/options` 2> /dev/null\"") || (echo "===> Cannot create `/usr/bin/dirname /var/db/ports/glib20/options`, check permissions"; exit 1) If I run that on the command line, it works ok. Perhaps this is make(1) breakage. I'll look into it a bit later when I have some time. -- Brian Somers Don't _EVER_ lose your sense of humour !