From owner-cvs-src@FreeBSD.ORG Thu Oct 25 19:49:18 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A9E216A421; Thu, 25 Oct 2007 19:49:18 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id A4A5413C4A3; Thu, 25 Oct 2007 19:49:17 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l9PJnAef015995; Thu, 25 Oct 2007 15:49:11 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Thu, 25 Oct 2007 15:49:11 -0400 (EDT) Date: Thu, 25 Oct 2007 15:49:10 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Andrey Chernov In-Reply-To: <20071025192618.GH16187@nagual.pp.ru> Message-ID: References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720C7D6.9090004@delphij.net> <20071025190019.GA16187@nagual.pp.ru> <4720E9E1.7000900@delphij.net> <4720EC70.8@delphij.net> <20071025192618.GH16187@nagual.pp.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, Scott Long , src-committers@freebsd.org, d@delphij.net, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2007 19:49:18 -0000 On Thu, 25 Oct 2007, Andrey Chernov wrote: > On Thu, Oct 25, 2007 at 12:20:16PM -0700, LI Xin wrote: >> Daniel Eischen wrote: >>> Why not simply avoid the error check for inlines. Solaris >>> doesn't seem to add a check, it just does the conversion. >>> The non-inlined versions do error checking. >> >> I'll take a look at this and provide a patch for review. > > I don't think it is a good idea. Even lots current-on-current > programs becomes broken. Ok, just making a suggestion. I don't feel too strongly one way or the other. -- DE