From owner-cvs-all@FreeBSD.ORG Thu Jan 6 03:23:04 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2B7E7106566C; Thu, 6 Jan 2011 03:23:04 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from mail14.syd.optusnet.com.au (mail14.syd.optusnet.com.au [211.29.132.195]) by mx1.freebsd.org (Postfix) with ESMTP id AC2018FC0A; Thu, 6 Jan 2011 03:23:03 +0000 (UTC) Received: from server.vk2pj.dyndns.org (c220-239-116-103.belrs4.nsw.optusnet.com.au [220.239.116.103]) by mail14.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id p063N0cG000568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 6 Jan 2011 14:23:01 +1100 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.4/8.14.4) with ESMTP id p063MxJQ065022; Thu, 6 Jan 2011 14:22:59 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.4/8.14.4/Submit) id p063Mx9T065021; Thu, 6 Jan 2011 14:22:59 +1100 (EST) (envelope-from peter) Date: Thu, 6 Jan 2011 14:22:59 +1100 From: Peter Jeremy To: gahr@FreeBSD.org Message-ID: <20110106032259.GB62507@server.vk2pj.dyndns.org> References: <201012200900.oBK90cfc062324@repoman.freebsd.org> <20101220103733.GA6738@FreeBSD.org> <20101220110727.GT7557@gahrfit.gahr.ch> <20101230161846.16ad0b3c.stas@FreeBSD.org> <20110104092747.GJ72669@gahrfit.gahr.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/" Content-Disposition: inline In-Reply-To: <20110104092747.GJ72669@gahrfit.gahr.ch> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Stanislav Sedov , cvs-ports@FreeBSD.org, Alexey Dokuchaev , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/freeimage Makefile distinfo pkg-descr ports/graphics/freeimage/files patch-Source-LibOpenJPEG_opj_malloc.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jan 2011 03:23:04 -0000 --pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2011-Jan-04 10:27:47 +0100, Pietro Cerutti wrote: >Well I tend to disagree here. I see a commit message as a way to convey >important notes about a commit. And I see a commit message as explaining _why_ the change was made. >I would like to avoid to have to write a line like this > >- add a patch file to fix an include line that used the deprecated > header alloc.h instead of stdlib.h > >for a patch file like this > >- #include >+ #include OTOH, I would like to see such a patch file documented along the lines of: - Patch to replace deprecated alloc.h with stdlib.h (But I wouldn't make fuss if it was skipped). --=20 Peter Jeremy --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (FreeBSD) iEYEARECAAYFAk0lNZMACgkQ/opHv/APuIcfKACdFK4vE90RbzuMtkBmXI8kP1N4 HzAAnRRmwZmXXS55PRJTeApIj08FkgDC =DJNK -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/--