From owner-cvs-libexec  Wed Jul 26 10:45:40 1995
Return-Path: cvs-libexec-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.11/8.6.6) id KAA01296
          for cvs-libexec-outgoing; Wed, 26 Jul 1995 10:45:40 -0700
Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241])
          by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id KAA01284
          ; Wed, 26 Jul 1995 10:45:35 -0700
Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id KAA25820; Wed, 26 Jul 1995 10:45:26 -0700
From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Message-Id: <199507261745.KAA25820@gndrsh.aac.dev.com>
Subject: Re: cvs commit: src/libexec/bootpd Makefile
To: wpaul@freefall.cdrom.com (Bill Paul)
Date: Wed, 26 Jul 1995 10:45:26 -0700 (PDT)
Cc: CVS-commiters@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com
In-Reply-To: <199507261421.HAA20977@freefall.cdrom.com> from "Bill Paul" at Jul 26, 95 07:21:41 am
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 1409      
Sender: cvs-libexec-owner@freebsd.org
Precedence: bulk

> 
> 
> > > wpaul       95/07/25 16:38:41
> > > 
> > >   Modified:    libexec/bootpd  Makefile
> > >   Log:
> > >   Uncomment 'CFLAGS+=ETC_ETHERS' -- we have support for this as of 2.0.5.
> > 
> > That should be:
> > COPTS+=ETC_ETHERS
> > 
> > CFLAGS is an undocumented internal of the .mk files.  Please see 
> > /usr/src/share/mk/bsd.README
> > 
> > -- 
> > Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
> > Accurate Automation Company                 Reliable computers for FreeBSD
> 
> Don't look at me: all I did was take away the hash mark. :)

:-)  Disabled wrong code is one thing that does not break tools,
enabled wrong code can (and does for me) break tools.  :-) :-)

> (BTW, I made a mind-o in the log message: I meant to say -DETC_ETHERS.
> Doesn't matter though.)
> 
> If this is true, then there are a bunch of Makefiles all over
> the place that are wrong (a few of which are, admittedly, my doing).
> Would you like me to make it a personal mission to fix these whenever
> I find them?

Technically I told someone I would go fix the whole of the rest of
the tree if he fixed one place he had done similiar things only to
a far greater extent, but if you want to help me clean these out
that would be great!

-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                 Reliable computers for FreeBSD