Date: Wed, 17 Jul 2013 21:00:38 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r253427 - head/sbin/route Message-ID: <20130718010038.GD2264@glenbarber.us> In-Reply-To: <201307171405.r6HE5KpR005269@svn.freebsd.org> References: <201307171405.r6HE5KpR005269@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--9crTWz/Z+Zyzu20v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 17, 2013 at 02:05:20PM +0000, Hiroki Sato wrote: > Author: hrs > Date: Wed Jul 17 14:05:20 2013 > New Revision: 253427 > URL: http://svnweb.freebsd.org/changeset/base/253427 >=20 > Log: > - Add support of MK_INET_SUPPORT=3Dno. > - Fix a bug in sodump() which prevented struct sockaddr_in6 from displa= ying. > - Fix a bug in in fiboptlist_csv() which could cause free() of uninitia= lized > pointer. > - Style cleanups: > . Add missing "static" keywords. > . Use an array of struct sockaddr_storage instead of sockunion for rtm= sg. > . Use err() and errx() instead of pair of fprintf(stderr, "...") + exi= t(1). > . Use nitems() macro. > . Various style(9) fixes. >=20 > Modified: > head/sbin/route/Makefile > head/sbin/route/route.c >=20 [...] > Modified: head/sbin/route/route.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sbin/route/route.c Wed Jul 17 14:04:18 2013 (r253426) > +++ head/sbin/route/route.c Wed Jul 17 14:05:20 2013 (r253427) [...] > @@ -1470,14 +1498,12 @@ rtmsg(int cmd, int flags, int fib) > rtm.rtm_rmx =3D rt_metrics; > rtm.rtm_inits =3D rtm_inits; > =20 > - if (rtm_addrs & RTA_NETMASK) > - mask_addr(); > - NEXTADDR(RTA_DST, so_dst); > - NEXTADDR(RTA_GATEWAY, so_gate); > - NEXTADDR(RTA_NETMASK, so_mask); > - NEXTADDR(RTA_GENMASK, so_genmask); > - NEXTADDR(RTA_IFP, so_ifp); > - NEXTADDR(RTA_IFA, so_ifa); > + NEXTADDR(RTA_DST, so[RTAX_DST]); > + NEXTADDR(RTA_GATEWAY, so[RTAX_GATEWAY]); > + NEXTADDR(RTA_NETMASK, so[RTAX_NETMASK]); > + NEXTADDR(RTA_GENMASK, so[RTAX_GENMASK]); > + NEXTADDR(RTA_IFP, so[RTAX_IFP]); > + NEXTADDR(RTA_IFA, so[RTAX_IFA]); > rtm.rtm_msglen =3D l =3D cp - (char *)&m_rtmsg; > if (verbose) > print_rtmsg(&rtm, l); I think this breaks head/, at least for ia64. LC_ALL=3DC awk '!/^#|^$/ { printf "#define\tK_%s\t%d\n\t{\"%s\", K_%s},\n"= , toupper($1), ++L, $1, toupper($1); }' < /src/sbin/route/keywords > keywords.h || (rm -f keywords.h; false) rm -f .d= epend CC=3D'cc ' mkdep -f .depend -a -DNS -DINET -DINET6 -I. -DRESCUE -std=3Dg= nu99 /src/sbin/route/route.c echo route: /obj/ia64.ia64/src/tmp/usr/lib/libc.a >> .depend cc -O2 -pipe -DNS -DINET -DINET6 -I. -DRESCUE -std=3Dgnu99 -Wsystem-heade= rs -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-uninitialized= -Wno-pointer-sign -c /src/sbin/route/route.c cc1: warnings being treated as errors /src/sbin/route/route.c: In function 'rtmsg': /src/sbin/route/route.c:1491: warning: the address of 'so' will always evaluate as 'true' *** Error code 1 Stop. make: stopped in /src/sbin/route *** Error code 1 Stop. make: stopped in /obj/ia64.ia64/src/rescue/rescue *** Error code 1 Stop. make: stopped in /src/rescue/rescue *** Error code 1 Stop. make: stopped in /src/rescue *** Error code 1 Stop. make: stopped in /src *** Error code 1 Stop. make: stopped in /src *** Error code 1 Stop in /src. TB --- 2013-07-18 00:50:37 - WARNING: /usr/bin/make returned exit code 1 TB --- 2013-07-18 00:50:37 - ERROR: failed to build world TB --- 2013-07-18 00:50:37 - 3190.01 user 612.41 system 4046.74 real http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-ia64-ia64.full Glen --9crTWz/Z+Zyzu20v Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBCAAGBQJR5z42AAoJEFJPDDeguUajYDUH/1vT+PKuWPgDs3FkjcIIPi+S bdfGv1KGV94G64ocWM1qWLfAKjOWAdYSjhvwY7B5v5QGf35R3fFAeGWeMQDFu5hU Yj+ZJtIYMlMnTynSfO+AlL20CzPS03M7w7pMPEX5mjKJpkYb/eaqsavhTlXbG6MT ot5nGcy9MX95T6V9jQ94DoLNnCYBSbs7SxLToNfbyrQuVAcHJEub17oFJQgKhRzR pGWhqqGe9+wHqjs97F6iBPAjLO66yTlVsRihmk+uf6LSGV7VPyyLW59F21WgIMD1 DHZ2nJbrTtAzMjmbnsMkAOC1Jbf46RLMfiQcNZK4F0qhzJTztFsW3H78qCiGUFM= =EIvR -----END PGP SIGNATURE----- --9crTWz/Z+Zyzu20v--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130718010038.GD2264>