Date: Fri, 05 Oct 2012 20:26:21 +0200 From: Alex Dupre <ale@FreeBSD.org> To: glarkin@FreeBSD.org Cc: gnome@FreeBSD.org, Joe Marcus Clarke <marcus@freebsd.org>, autotools@FreeBSD.org Subject: Re: charset.alias Message-ID: <506F264D.1090906@FreeBSD.org> In-Reply-To: <506F1997.7090400@FreeBSD.org> References: <506F01C4.6040704@FreeBSD.org> <506F0B56.6060208@FreeBSD.org> <506F163F.4090403@FreeBSD.org> <506F1997.7090400@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Greg Larkin ha scritto: > I included the charset.alias data generated by the devel/patch build > itself (config.charset script, IIRC), and I followed the spirit of the > existing code in the application in deciding to embed it within an > #if/#endif block. Yep, but such scripts/code are taken from libiconv 'as-is': http://git.savannah.gnu.org/cgit/libiconv.git/tree/libcharset/lib We have patched libiconv in the tree to create the correct charset.alias, so it makes sense to use it (since it doesn't require code modification in other applications) instead of patching localcharset.c in every program that bundle it. > Since I am no expert on charsets, libiconv or gettext, please feel > free to replace my fix with your patch, if that's a better long-term > solution. Let's hear other opinions. -- Alex Dupre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?506F264D.1090906>