From owner-freebsd-gnome@FreeBSD.ORG Fri Oct 5 18:26:21 2012 Return-Path: Delivered-To: gnome@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C81A8106566B for ; Fri, 5 Oct 2012 18:26:21 +0000 (UTC) (envelope-from ale@FreeBSD.org) Received: from lab.alexdupre.com (alexdupre-1-pt.tunnel.tserv23.zrh1.ipv6.he.net [IPv6:2001:470:25:450::2]) by mx1.freebsd.org (Postfix) with ESMTP id 059C08FC0C for ; Fri, 5 Oct 2012 18:26:20 +0000 (UTC) Received: (qmail 24198 invoked from network); 5 Oct 2012 18:26:19 -0000 Received: from atom.alexdupre.com (HELO ?192.168.178.12?) (sysadmin@alexdupre.com@192.168.178.12) by lab.alexdupre.com with ESMTPSA; 5 Oct 2012 18:26:19 -0000 Message-ID: <506F264D.1090906@FreeBSD.org> Date: Fri, 05 Oct 2012 20:26:21 +0200 From: Alex Dupre User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120909 Firefox/15.0.1 SeaMonkey/2.12.1 MIME-Version: 1.0 To: glarkin@FreeBSD.org References: <506F01C4.6040704@FreeBSD.org> <506F0B56.6060208@FreeBSD.org> <506F163F.4090403@FreeBSD.org> <506F1997.7090400@FreeBSD.org> In-Reply-To: <506F1997.7090400@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: gnome@FreeBSD.org, Joe Marcus Clarke , autotools@FreeBSD.org Subject: Re: charset.alias X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2012 18:26:21 -0000 Greg Larkin ha scritto: > I included the charset.alias data generated by the devel/patch build > itself (config.charset script, IIRC), and I followed the spirit of the > existing code in the application in deciding to embed it within an > #if/#endif block. Yep, but such scripts/code are taken from libiconv 'as-is': http://git.savannah.gnu.org/cgit/libiconv.git/tree/libcharset/lib We have patched libiconv in the tree to create the correct charset.alias, so it makes sense to use it (since it doesn't require code modification in other applications) instead of patching localcharset.c in every program that bundle it. > Since I am no expert on charsets, libiconv or gettext, please feel > free to replace my fix with your patch, if that's a better long-term > solution. Let's hear other opinions. -- Alex Dupre