From owner-freebsd-geom@FreeBSD.ORG  Tue Jan 22 16:29:13 2013
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 2214ED56;
 Tue, 22 Jan 2013 16:29:13 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 84FAA14D;
 Tue, 22 Jan 2013 16:29:11 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
 [212.40.38.101])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA01196;
 Tue, 22 Jan 2013 18:29:09 +0200 (EET) (envelope-from avg@FreeBSD.org)
Message-ID: <50FEBE55.1040009@FreeBSD.org>
Date: Tue, 22 Jan 2013 18:29:09 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130113 Thunderbird/17.0.2
MIME-Version: 1.0
To: freebsd-geom@FreeBSD.org
Subject: Re: kern/175323: Fail to use ZVOL as a gmirror component
References: <50FD0E99.8010305@FreeBSD.org>
 <CAKNWxEU8PVtnRrN6+Esx835OHqSGSbgWV9xCOzVjUXKmZQvaLA@mail.gmail.com>
In-Reply-To: <CAKNWxEU8PVtnRrN6+Esx835OHqSGSbgWV9xCOzVjUXKmZQvaLA@mail.gmail.com>
X-Enigmail-Version: 1.4.6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GEOM-specific discussions and implementations
 <freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-geom>,
 <mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
 <mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jan 2013 16:29:13 -0000

on 21/01/2013 14:39 Алексей Волков said the following:
> Eventually this patch works for me just fine.
> 
> --- sys/geom/mirror/g_mirror.c    (revision 245741)
> +++ sys/geom/mirror/g_mirror.c    (working copy)
> @@ -456,7 +456,7 @@
>      disk->d_flags = md->md_dflags;
>      error = g_getattr("GEOM::candelete", disk->d_consumer, &i);
>      if (error != 0)
> -        goto fail;
> +        i=0;
>      if (i)
>          disk->d_flags |= G_MIRROR_DISK_FLAG_CANDELETE;
>      if (md->md_provider[0] != '\0')
> 

So any comments from the GEOM / gmirror guys?

-- 
Andriy Gapon