From owner-cvs-sys  Tue Mar 21 22:09:05 1995
Return-Path: cvs-sys-owner
Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id WAA22516 for cvs-sys-outgoing; Tue, 21 Mar 1995 22:09:05 -0800
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id WAA22500; Tue, 21 Mar 1995 22:08:32 -0800
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id QAA04399; Wed, 22 Mar 1995 16:04:06 +1000
Date: Wed, 22 Mar 1995 16:04:06 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199503220604.QAA04399@godzilla.zeta.org.au>
To: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com,
        davidg@freefall.cdrom.com
Subject: Re: cvs commit: src/sys/i386/isa wd.c wdreg.h
Sender: cvs-sys-owner@freebsd.org
Precedence: bulk

>  Modified:    sys/i386/isa wd.c wdreg.h
>  Log:
>  Fixes and improvements from John Dyson:
>  
>  Fixed the I/O statistics
>  Allow WD1007 type controllers to work
>  Support MULTI-BLOCK I/O
>  Correct delay to use port 0x84, reading the status register
>  might not be a long enough delay.
>  Changed probe message to match SCSI type devices.

Please don't fix or improve wd.c or sd.c any more until the sliced
versions are committed.

I've fixed the I/O statistics too.

I used a WD1007 for 2 years.  Who broke the support for it? :-).

The delay needs to be done better.  First, 1.x usec for an inb() is at
least (0.550 + 0.x) usec wasted.  Second, some machines are reported
to optimize some motherboard inb()s.  I think reading the status register
is more likely to give a long enough delay since the register is (much)
more likely to be on the bus.

I've fixed the probe message too, but not to match the recently censored
SCSI messages.  It was broken with the help of bogus indentation in
revision 1.31.

Bruce