Date: Mon, 19 Mar 2012 18:58:36 -0700 From: Greg Lewis <glewis@eyesbeyond.com> To: Jason Helfman <jgh@FreeBSD.org> Cc: freebsd-eclipse@FreeBSD.org, Jung-uk Kim <jkim@FreeBSD.org>, freebsd-java@FreeBSD.org Subject: Re: [RFC] New Port: Eclipse Java Compiler, java/eclipse-ecj Message-ID: <20120320015836.GA83617@misty.eyesbeyond.com> In-Reply-To: <20120319230818.GJ46825@dormouse.experts-exchange.com> References: <20120318180225.GA51618@dormouse.experts-exchange.com> <20120319193152.GD46825@dormouse.experts-exchange.com> <20120319215933.GG46825@dormouse.experts-exchange.com> <201203191900.42677.jkim@FreeBSD.org> <20120319230818.GJ46825@dormouse.experts-exchange.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 19, 2012 at 04:08:18PM -0700, Jason Helfman wrote: > On Mon, Mar 19, 2012 at 07:00:39PM -0400, Jung-uk Kim thus spake: > >Hmm... It doesn't seem right. > > > >% cat /usr/local/bin/ecj.sh > >#!/bin/sh > > > >/usr/local/openjdk6/bin/javac -classpath /usr/local/share/java/classes/ecj.jar $1 > >% /usr/local/bin/ecj.sh -version > >javac 1.6.0_30 > >% /usr/local/openjdk6/bin/javac -version > >javac 1.6.0_30 > > > >Please note it isn't coming from ecj.jar. > > That is grabbing the version of javac based on the shell script. > I'm not certain if you can get a vesion of the jar with an argument, or if > that argument is even valid. > > > >Also, `$1' should be `$*'. I could be wrong, but I thought the preferred version of this was "$@" (as is, including the double quotes). IIRC using $* doesn't quite work properly if some of your arguments have spaces in them. Instead of %%JAVAC%% I'd suggest %%LOCALBASE%%/bin/javac so that the selection of which JDK to use can be done at run time rather than port install time. Note that I haven't tested the port though, so YMMV. > I can change this. > > > >Thanks for working on this, BTW. > > Your very welcome :) > > > >Jung-uk Kim > > > > -- > Jason Helfman | FreeBSD Committer > jgh@FreeBSD.org | http://people.freebsd.org/~jgh -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120320015836.GA83617>