From owner-freebsd-ports@FreeBSD.ORG Thu Mar 31 21:25:53 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8D73106564A for ; Thu, 31 Mar 2011 21:25:53 +0000 (UTC) (envelope-from inyaoo@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 678F08FC0C for ; Thu, 31 Mar 2011 21:25:53 +0000 (UTC) Received: by wyf23 with SMTP id 23so2901594wyf.13 for ; Thu, 31 Mar 2011 14:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=/+U1KUyZQDWtaBtWdVPybHssFvEMmOOU6lUKxZTFZ1Q=; b=HcAVPzxxv0MaSQGqM9Ov4xqydRity8s3WMUA6g8Y+Q4i5t1jtX3YZ2ohxRzxbewu/9 fNoiXI037aRM8TrwsXkooNjPxy2zXV8vLL9ETVVucyO7XCRDFssCSsosplzSgPHVI5dO /1fqwKMAWFiJRXF2nk8dzKMXIMBDrtRj/dLy4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=K/N9+WkqgjViomQu+MSOfe3OGB6C0FCbhEtUdkGLORN9b7s2B9yxX+n59ofoVWT1cv rI7ZCXJmBSsOoy7WpIKrrp37rPdLjqnUqlw0Cx3hVjlCb1Q/+tdQFDk17mljWB9BVMal CwWRissnMLhzIn8m6GxDBkNIOvBGsfij6XW2M= Received: by 10.227.36.209 with SMTP id u17mr3244171wbd.117.1301606752063; Thu, 31 Mar 2011 14:25:52 -0700 (PDT) Received: from localhost (zeller.torservers.net [74.120.12.135]) by mx.google.com with ESMTPS id bs4sm901650wbb.1.2011.03.31.14.25.45 (version=SSLv3 cipher=OTHER); Thu, 31 Mar 2011 14:25:47 -0700 (PDT) From: Pan Tsu To: Chris Rees References: Date: Fri, 01 Apr 2011 01:25:39 +0400 In-Reply-To: (Chris Rees's message of "Thu, 31 Mar 2011 19:01:21 +0100") Message-ID: <86oc4rf0do.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: freebsd-ports@freebsd.org Subject: Re: [SOLVED] PORTDOCS strangeness X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2011 21:25:53 -0000 Chris Rees writes: > On 30 March 2011 21:00, Chris Rees wrote: >> Hi all, >> >> I'm updating castor to the new version (thanks for the email >> Portscout!), and I've decided to add in docs option. >> >> However... when I set PORTDOCS= * as normal, on deinstall it complains >> about being unable to remove ${DOCSDIR}, yet it has been deleted. I've seen similar errors when one *explicitly* adds @dirrm for ${DOCSDIR}. >> >> I've looked in +CONTENTS after installing it, and sure enough there's >> a @dirrm share/doc/castor. What 'gotchas' are there with PORTDOCS? >> >> It installs ~70 docfiles, so I was hoping not to have to list it in >> pkg-plist, for the sake of space if anything else! > > After some kind advice from b.f., I've tracked it down (I think). > > As far as I can see, you can't use PORTDOCS= * when there are > directories inside ${DOCSDIR}, for some reason. Are you sure? The following diff doesn't produce any errors here. %% Index: java/castor/Makefile =================================================================== RCS file: /a/.cvsup/ports/java/castor/Makefile,v retrieving revision 1.14 diff -u -p -r1.14 Makefile --- java/castor/Makefile 1 Jul 2010 21:13:01 -0000 1.14 +++ java/castor/Makefile 31 Mar 2011 21:21:33 -0000 @@ -28,6 +28,7 @@ JARSUFXS= -anttasks.jar \ -xml.jar \ .jar +PORTDOCS= * PLIST_FILES= %%JAVAJARDIR%%/${PORTNAME}-anttasks.jar \ %%JAVAJARDIR%%/${PORTNAME}-codegen.jar \ %%JAVAJARDIR%%/${PORTNAME}-core.jar \ @@ -44,5 +45,9 @@ do-install: ${JAVAJARDIR}/${PORTNAME}${f} @${ECHO_MSG} " [ DONE ]" .endfor + @${ECHO_MSG} -n ">> Installing documentation under ${DOCSDIR}..." + @${MKDIR} ${DOCSDIR} + @${TAR} cf - -C${WRKSRC}/doc . | ${TAR} xof - -C${DOCSDIR} + @${ECHO_MSG} " [ DONE ]" .include %%