From owner-svn-ports-all@FreeBSD.ORG  Fri Feb  7 13:13:20 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 20447103;
 Fri,  7 Feb 2014 13:13:20 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id E9FE01AB4;
 Fri,  7 Feb 2014 13:13:16 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id CECC5438BE;
 Fri,  7 Feb 2014 07:12:54 -0600 (CST)
Message-ID: <52F4DBC4.1010900@marino.st>
Date: Fri, 07 Feb 2014 14:12:36 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Martin Wilke <miwi@FreeBSD.org>
Subject: Re: svn commit: r343229 - head/graphics/libgphoto2
References: <201402071306.s17D6ete020177@svn.freebsd.org>
In-Reply-To: <201402071306.s17D6ete020177@svn.freebsd.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Feb 2014 13:13:20 -0000

On 2/7/2014 14:06, Martin Wilke wrote:
> Author: miwi
> Date: Fri Feb  7 13:06:39 2014
> New Revision: 343229
> URL: http://svnweb.freebsd.org/changeset/ports/343229
> QAT: https://qat.redports.org/buildarchive/r343229/
> 
> Log:
>   - Update to 2.5.3.1
>   
>   PR:		185940
>   Submitted by:	Ports Fury
> 
> Modified:
>   head/graphics/libgphoto2/Makefile
>   head/graphics/libgphoto2/distinfo
> 
> Modified: head/graphics/libgphoto2/Makefile
> ==============================================================================
> --- head/graphics/libgphoto2/Makefile	Fri Feb  7 13:05:57 2014	(r343228)
> +++ head/graphics/libgphoto2/Makefile	Fri Feb  7 13:06:39 2014	(r343229)

> -.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000040
> +.if ${OPSYS} == "FreeBSD" && ${OSVERSION} < 1000040
>  CONFIGURE_ENV+=	LIBUSB1_CFLAGS=" " LIBUSB1_LIBS="-lusb"
>  .endif

Was this^^^^ some kind of style violation?
The pkgsrc guys get mad if quotes are used where they are not needed.
Why were quotes added here where clearly they are optional?

John