Date: Wed, 19 Nov 2003 08:41:31 +0000 From: Mark Murray <mark@grondar.org> To: Nate Lawson <nate@root.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_intr.c Message-ID: <200311190841.hAJ8fVDw043136@grimreaper.grondar.org> In-Reply-To: Your message of "Tue, 18 Nov 2003 16:46:24 PST." <20031118163849.S65744@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Lawson writes: > > > Hackfix to patch around a kernel panic I introduced. Real fix to > > > follow. In the meanwhile, we are not harvesting interrupt entropy. > > > > > > Approved by: re (jhb) > > > > The correct fix is approximately to back out the changes to the > > harvester. It needs to use preallocated storage like it used to since > > it is called from nearly the lowest level of interrupt handling when > > neither malloc() nor sleep locks may be used. Using preallocated storage > > also simplifies the locking. > > I agree. Separating the buffer into per-source buffers does not require > changing from a ring buffer to a malloc/FIFO model. Its not quite as simple as that. :-) A single ring-buffer is badly suboptimal, as it doesn't handle changes in the order of the buffer elements well. I am stress-testing a new malloc-free (well, it mallocs at init time) version version. This uses preallocated buffer elements, and cycles them through a fifo (in this case, very nearly a ring buffer, but allowing the contents to become disordered). M -- Mark Murray iumop ap!sdn w,I idlaH
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200311190841.hAJ8fVDw043136>