From owner-svn-src-all@FreeBSD.ORG Mon Dec 28 19:08:54 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51532106566B; Mon, 28 Dec 2009 19:08:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 23C9F8FC17; Mon, 28 Dec 2009 19:08:54 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id CB2C946B46; Mon, 28 Dec 2009 14:08:53 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 8D0E98A01D; Mon, 28 Dec 2009 14:08:52 -0500 (EST) From: John Baldwin To: Jack F Vogel Date: Mon, 28 Dec 2009 13:57:04 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.2-CBSD-20091103; KDE/4.3.1; amd64; ; ) References: <200911111913.nABJDewR004319@svn.freebsd.org> In-Reply-To: <200911111913.nABJDewR004319@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <200912281357.04461.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 28 Dec 2009 14:08:52 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r199192 - head/sys/dev/e1000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2009 19:08:54 -0000 On Wednesday 11 November 2009 2:13:40 pm Jack F Vogel wrote: > Author: jfv > Date: Wed Nov 11 19:13:40 2009 > New Revision: 199192 > URL: http://svn.freebsd.org/changeset/base/199192 > > Log: > With an i386 kernel the igb driver can cause a > page fault panic on initialization due to a large > number of bounce pages being allocated. This is due > to the dma tag requiring page alignment on mbuf mapping. > This was removed some time back from the ixgbe driver > and is not needed here either. > > Modified: > head/sys/dev/e1000/if_igb.c > > Modified: head/sys/dev/e1000/if_igb.c > ============================================================================== > --- head/sys/dev/e1000/if_igb.c Wed Nov 11 19:00:12 2009 (r199191) > +++ head/sys/dev/e1000/if_igb.c Wed Nov 11 19:13:40 2009 (r199192) > @@ -2654,7 +2654,7 @@ igb_dma_malloc(struct adapter *adapter, > int error; > > error = bus_dma_tag_create(bus_get_dma_tag(adapter->dev), /* parent */ > - IGB_DBA_ALIGN, 0, /* alignment, bounds */ > + 1, 0, /* alignment, bounds */ > BUS_SPACE_MAXADDR, /* lowaddr */ > BUS_SPACE_MAXADDR, /* highaddr */ > NULL, NULL, /* filter, filterarg */ em(4) still has EM_DBA_ALIGN for em_dma_alloc(), but it uses '1' for the align for RX and TX buffers. Should this specific tag be changed back to using IGB_DBA_ALIGN or should em(4) be changed to use '1' for em_dma_alloc()? -- John Baldwin