From owner-freebsd-ports@FreeBSD.ORG Fri Jan 18 13:59:00 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 831EE16A418; Fri, 18 Jan 2008 13:59:00 +0000 (UTC) (envelope-from jdc@parodius.com) Received: from mx01.sc1.parodius.com (mx01.sc1.parodius.com [72.20.106.3]) by mx1.freebsd.org (Postfix) with ESMTP id 5240313C46B; Fri, 18 Jan 2008 13:59:00 +0000 (UTC) (envelope-from jdc@parodius.com) Received: by mx01.sc1.parodius.com (Postfix, from userid 1000) id 60DD81CC076; Fri, 18 Jan 2008 05:59:00 -0800 (PST) Date: Fri, 18 Jan 2008 05:59:00 -0800 From: Jeremy Chadwick To: Stanislav Sedov Message-ID: <20080118135900.GA38857@eos.sc1.parodius.com> References: <20080115000449.GA94650@eos.sc1.parodius.com> <20080118132532.GL22695@dracon.ht-systems.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080118132532.GL22695@dracon.ht-systems.ru> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-ports@freebsd.org, miwi@freebsd.org Subject: Re: www/mod_dosevasive20 vs. www/mod_evasive20 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2008 13:59:00 -0000 On Fri, Jan 18, 2008 at 04:25:32PM +0300, Stanislav Sedov wrote: > On Mon, Jan 14, 2008 at 04:04:49PM -0800 Jeremy Chadwick mentioned: > > One of our customers pointed out to me that there's two versions of the > > mod_evasive module actively floating around in ports: > > > > ports/www/mod_evasive20 > > ports/www/mod_dosevasive20 > > > > Based on PR 106870 and the CVS commit logs, it looks like a repocopy > > was done from mod_dosevasive20 --> mod_evasive20 (since the software > > itself was renamed identically): > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=106870 > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/www/mod_dosevasive20/Makefile > > > > However, mod_dosevasive20 was never removed/deprecated. This lead to > > some confusion... Can anything be done about this for consistency > > reasons? > > > > I beleive the mod_dosevasive20 port should be dropped due to rename. I agree. However, look at www/mod_evasive20/Makefile's PORTNAME: $ grep ^PORTNAME /usr/ports/www/mod_evasive20/Makefile PORTNAME= mod_dosevasive20 This is obviously incorrect. My customer is a bit perturbed by this, and rightfully so. And although I myself am a FreeBSD ports committer, I don't believe in blindly fixing this without discussion first. > Have you tired contacting the maintainer? No, I haven't. I did CC miwi@ who was responsible for the repocopy and handling the PR; I think the above PORTNAME mistake was something that slipped by, but it's obviously going to confuse people. Of course, I'm also left wondering how portlint didn't catch this, how Bill Fenner's automatic port builds didn't catch it, and how INDEX generation didn't catch it. (Can you tell I'm new here? :-) ) -- | Jeremy Chadwick jdc at parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. PGP: 4BD6C0CB |