From owner-svn-src-head@FreeBSD.ORG  Sun Aug  2 19:29:02 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9FA39106564A;
	Sun,  2 Aug 2009 19:29:02 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 84EDE8FC14;
	Sun,  2 Aug 2009 19:29:02 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 57EEC1A3C6C; Sun,  2 Aug 2009 12:29:02 -0700 (PDT)
Date: Sun, 2 Aug 2009 12:29:02 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Robert Watson <rwatson@FreeBSD.org>
Message-ID: <20090802192902.GS47463@elvis.mu.org>
References: <200907300014.n6U0EZ77086341@svn.freebsd.org>
	<d04e16b70907310045y635245efob33b10464c22524f@mail.gmail.com>
	<20090731212140.GK47463@elvis.mu.org>
	<200908010615.02972.hselasky@c2i.net>
	<alpine.BSF.2.00.0908012313500.1507@fledge.watson.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.BSF.2.00.0908012313500.1507@fledge.watson.org>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Navdeep Parhar <nparhar@gmail.com>,
	Hans Petter Selasky <hselasky@c2i.net>
Subject: Re: svn commit: r195960 - in head/sys/dev/usb: . controller input
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Aug 2009 19:29:03 -0000

* Robert Watson <rwatson@FreeBSD.org> [090801 15:15] wrote:
> 
> On Sat, 1 Aug 2009, Hans Petter Selasky wrote:
> 
> >>>This has slowed down core dumps very significantly.  What used to take 
> >>>10-15s on my system now takes around 3 minutes.  A simple test is to 
> >>>break into ddb and "call doadump" with or without this rev.  I have a 
> >>>serial console on this machine and so I can use ddb whether the attached 
> >>>USB keyboard works or not.
> >
> >It's because there is a DELAY(1000) in the UKBD's polling routine so that 
> >key- repeating will work, no magic.
> 
> Given a choice between dumping 10x faster and having automatic key repeat 
> in DDB, I'd lean towards the former.  :-)
> 

Robert, and *@freebsd.org,

Hans should be back in a day or so to address this.  If critical I can
probably back out the offending code, but I think it makes sense to
wait a few days more for a more comprehensive fix.


-- 
- Alfred Perlstein
.- AMA, VMOA #5191, 03 vmax, 92 gs500, 85 ch250
.- FreeBSD committer