From owner-freebsd-bugs  Thu Sep 27  1: 0:26 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 9C42637B435
	for <freebsd-bugs@hub.freebsd.org>; Thu, 27 Sep 2001 01:00:02 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f8R802u48056;
	Thu, 27 Sep 2001 01:00:02 -0700 (PDT)
	(envelope-from gnats)
Received: from xkulesh.vol.cz (xkulesh.vol.cz [195.250.154.106])
	by hub.freebsd.org (Postfix) with ESMTP id 2553D37B406
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Sep 2001 00:51:30 -0700 (PDT)
Received: (from root@localhost)
	by xkulesh.vol.cz (8.11.4/8.11.4) id f8R0s4R42280;
	Thu, 27 Sep 2001 02:54:04 +0200 (CEST)
	(envelope-from dan)
Message-Id: <200109270054.f8R0s4R42280@xkulesh.vol.cz>
Date: Thu, 27 Sep 2001 02:54:04 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.113
Subject: bin/30865: bootpd->readfile.c missing breaks in switch cause incorrect error report
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         30865
>Category:       bin
>Synopsis:       bootpd->readfile.c missing breaks in switch cause incorrect error report
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 27 01:00:02 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Dan Lukes
>Release:        FreeBSD 4.4-STABLE i386
>Organization:
Obludarium
>Environment:
System: FreeBSD 4.4-STABLE #31: Thu Sep 20 23:06:53 CEST 2001 i386

>Description:
	BOOTPD, file readfile.c 

	missing "break" statement in switch cause "unknown error"
reports instead of specific errors.

	typo "unkown" -> "unknown"

>How-To-Repeat:
>Fix:

--- libexec/bootpd/readfile.c.orig	Mon Mar  5 22:37:21 2001
+++ libexec/bootpd/readfile.c	Thu Sep 27 02:47:41 2001
@@ -697,10 +697,12 @@
 			break;
 		case E_BAD_PATHNAME:
 			msg = "bad pathname (need leading '/')";
+			break;
 		case E_BAD_VALUE:
 			msg = "bad value";
+			break;
 		default:
-			msg = "unkown error";
+			msg = "unknown error";
 			break;
 		}						/* switch */
 		report(LOG_ERR, "in entry named \"%s\", symbol \"%s\": %s",
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message