From owner-cvs-src@FreeBSD.ORG Fri Jun 30 16:54:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C634F16A512; Fri, 30 Jun 2006 16:54:20 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90DB843EB9; Fri, 30 Jun 2006 16:53:13 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k5UGqkO2081188; Fri, 30 Jun 2006 20:52:46 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k5UGqkWq081187; Fri, 30 Jun 2006 20:52:46 +0400 (MSD) (envelope-from yar) Date: Fri, 30 Jun 2006 20:52:46 +0400 From: Yar Tikhiy To: Gleb Smirnoff Message-ID: <20060630165246.GA81169@comp.chem.msu.su> References: <200606291922.k5TJM5ev007314@repoman.freebsd.org> <20060630114410.GZ1383@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060630114410.GZ1383@FreeBSD.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c if_atmsubr.c if_stf.c if_tun.c src/sys/netinet if_ether.c ip_divert.c ip_fw2.c src/sys/netinet6 in6.c in6_var.h src/sys/nfsclient bootp_subr.c nfs_diskless.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2006 16:54:20 -0000 On Fri, Jun 30, 2006 at 03:44:10PM +0400, Gleb Smirnoff wrote: > On Thu, Jun 29, 2006 at 07:22:05PM +0000, Yar Tikhiy wrote: > Y> Modified files: > Y> sys/net if.c if_atmsubr.c if_stf.c if_tun.c > Y> sys/netinet if_ether.c ip_divert.c ip_fw2.c > Y> sys/netinet6 in6.c in6_var.h > Y> sys/nfsclient bootp_subr.c nfs_diskless.c > Y> Log: > Y> There is a consensus that ifaddr.ifa_addr should never be NULL, > Y> except in places dealing with ifaddr creation or destruction; and > Y> in such special places incomplete ifaddrs should never be linked > Y> to system-wide data structures. Therefore we can eliminate all the > Y> superfluous checks for "ifa->ifa_addr != NULL" and get ready > Y> to the system crashing honestly instead of masking possible bugs. > Y> > Y> Suggested by: glebius, jhb, ru > > I think this can also close few reports from Coverity. The only report I was aware of was CID 448. -- Yar