From owner-freebsd-stable@FreeBSD.ORG Thu Nov 25 12:08:33 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1C681065670; Thu, 25 Nov 2010 12:08:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 1ADF28FC0C; Thu, 25 Nov 2010 12:08:32 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id oAPC8SSl001521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 25 Nov 2010 14:08:28 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id oAPC8SeP023979; Thu, 25 Nov 2010 14:08:28 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id oAPC8SvA023978; Thu, 25 Nov 2010 14:08:28 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 25 Nov 2010 14:08:28 +0200 From: Kostik Belousov To: Adam Vande More Message-ID: <20101125120828.GN2392@deviant.kiev.zoral.com.ua> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EwkcXxk9GypvHnsl" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-stable@freebsd.org, fs@freebsd.org Subject: Re: top io mode X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Nov 2010 12:08:33 -0000 --EwkcXxk9GypvHnsl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 25, 2010 at 05:28:30AM -0600, Adam Vande More wrote: > top io doesn't seem to display stats when dealing direct with a block dev= ice > like so: >=20 > dd if=3D/dev/ada0 of=3D/dev/null >=20 > However if dd runs on a regular file eg >=20 > dd if=3Dtest.file of=3D/dev/null >=20 > then stats are reported in top. >=20 > Is this the expected behavior? I do not think so, and the patch at the end of the message worked for me. I cannot explain the if (!TD_IS_IDLETHREAD(curthread)) curthread->td_ru.ru_inblock++; checks that are done in vfs_bio.c. diff --git a/sys/kern/kern_physio.c b/sys/kern/kern_physio.c index d6be6e7..34072f3 100644 --- a/sys/kern/kern_physio.c +++ b/sys/kern/kern_physio.c @@ -57,10 +57,13 @@ physio(struct cdev *dev, struct uio *uio, int ioflag) for (i =3D 0; i < uio->uio_iovcnt; i++) { while (uio->uio_iov[i].iov_len) { bp->b_flags =3D 0; - if (uio->uio_rw =3D=3D UIO_READ) + if (uio->uio_rw =3D=3D UIO_READ) { bp->b_iocmd =3D BIO_READ; - else=20 + curthread->td_ru.ru_inblock++; + } else { bp->b_iocmd =3D BIO_WRITE; + curthread->td_ru.ru_oublock++; + } bp->b_iodone =3D bdone; bp->b_data =3D uio->uio_iov[i].iov_base; bp->b_bcount =3D uio->uio_iov[i].iov_len; --EwkcXxk9GypvHnsl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAkzuUbwACgkQC3+MBN1Mb4hR2gCeJPD4EX57RwABvMHlOVFQH9R7 kxgAoLT+Hl6uKW+Ku51AfM37cPRxcEUE =WP+7 -----END PGP SIGNATURE----- --EwkcXxk9GypvHnsl--