From nobody Wed Apr 1 16:03:14 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fm8sh0sQtz6Y3JD; Wed, 01 Apr 2026 16:03:20 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fm8sg5Yp4z3nR6; Wed, 01 Apr 2026 16:03:19 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775059399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vQrt1QIJVz30ol9q3OQCMjVPrcVRyIStH5nc1k6b8pg=; b=UNGZr1XW4Jao8G7DMYGA6uB2amt8ybWw+uG+qbdnBWwGToIE1mpRBZOMz7Iv+5sVG4CBB+ kGXfLsPwCOP+P874rCVgoOPMixrYiWiOctI0FxZ15HAraN8YdCAaC59lQo8nd7sePRl/jE 8OsmotTJ6kvO6U6MDWlmeTj9F5BT7WGQgIv9iX8uKO9ZzRSqR9bS4izBNfrq+BzMRE2hyb flIyH54bViX6lqv1IsmQvZK/fJlGaIyVvPdvfMotQPttRUTMAx3afOSLZnzWeLVeKXzHCJ XlnCfwzDyeJpVZ2rsAUZcl77UtfgyDBKs8ON1nkeJz7R2rZxbsL5rmTl+ZEY3g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1775059399; a=rsa-sha256; cv=none; b=X3ScHS1uJsoMVQMHrQnSCdmndyqyqVs09fWwmBECPIC0fYKjXpfqg+CoaYd9c43l0TqDeh 03Xj9UIfoegqn/Rt6+mqp/dmuERXb2AsfqpVOKn4GIsLe3JR2kUq8TtFK8j9OnNMULfadC qBz7+fX2pketVSI1833NqSRqmTZpuH6JinnGkOPzFnfjxzbbI/XvAW2/2rPl8XBoxrgbeW Gr/fXdlJE8ujjXpcj9DMkKT1IV/L3LzgPWC9W9JQ8nX7BTyqrQfY7bqs91x9P5miHrtz9i Xi25Iy1SnEQy5FRE3dH0NL8vGCFwxa4Gd2YzlEZl3F/hXeyqRPvJ2MCN7TU9VA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775059399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vQrt1QIJVz30ol9q3OQCMjVPrcVRyIStH5nc1k6b8pg=; b=EAKAkL82VTfmqnoztRNBxg2OOwr4yX9Z8+Qs6HYyhi9dgJnqfQJ2Gel+Ukl+1BYL3gPyPO fzYwtl6M66YF9bkZvUl7PKb7dIvuL58qyZoVv4kgauUSeygaZVN3Eh67iUS94P5Vytb5zH lP8Vw2c2lirBMzHL3kVd6EyGO6i1Key/7zTGs0wF49ZCpwCxO+24zAZmg06DVNIsu/+Xm8 OwOmx5Prnv8Xzih38RAWO1vwmWI/vbg0kCAI2Ix0oaNBRpOtPWwoOqTM7jo8X6Yxe2lG6h fK1Lgy9OGIeXl4CzSL6wKJfycNpdYgzKpOmroPRC9JzlLehEMjq8cvB5GlodFA== Received: from framework (61-227-204-72.dynamic-ip.hinet.net [61.227.204.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fm8sf2ZGDzjvs; Wed, 01 Apr 2026 16:03:18 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Wed, 1 Apr 2026 12:03:14 -0400 From: Mark Johnston To: "Bjoern A. Zeeb" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 607f6be6ec19 - main - rtadvd: Fix validation of the MTU parameter when parsing config Message-ID: References: <69cd0d71.1a157.2cbcbd77@gitrepo.freebsd.org> <8npqp22o-247n-ps59-65qr-n7n79n935s0@mnoonqbm.arg> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8npqp22o-247n-ps59-65qr-n7n79n935s0@mnoonqbm.arg> On Wed, Apr 01, 2026 at 03:25:44PM +0000, Bjoern A. Zeeb wrote: > On Wed, 1 Apr 2026, Mark Johnston wrote: > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=607f6be6ec19f49ff595226afe1c8aa6515c59a0 > > > > commit 607f6be6ec19f49ff595226afe1c8aa6515c59a0 > > Author: Mark Johnston > > AuthorDate: 2026-04-01 12:14:24 +0000 > > Commit: Mark Johnston > > CommitDate: 2026-04-01 12:19:35 +0000 > > > > rtadvd: Fix validation of the MTU parameter when parsing config > > > > MFC after: 1 week > > --- > > usr.sbin/rtadvd/config.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/usr.sbin/rtadvd/config.c b/usr.sbin/rtadvd/config.c > > index 83b2efb68303..c0af8f76ca49 100644 > > --- a/usr.sbin/rtadvd/config.c > > +++ b/usr.sbin/rtadvd/config.c > > @@ -619,7 +619,7 @@ getconfig_free_pfx: > > get_prefix(rai); > > > > MAYHAVE(val64, "mtu", 0); > > - if (val < 0 || val64 > 0xffffffff) { > > + if (val64 < 0 || val64 > 0xffffffff) { > > Forgive me for asking, but would a reasonable check possibly cap this > right away at 0xffff as I cannot see us having interfaces with an > MTU larger than that. > We just removed IPv6 Jumbograms (or still in review?) for similar reasons? The code does this several lines later, after truncating the value to a 32-bit integer. > > syslog(LOG_ERR, > > "<%s> mtu (%" PRIu64 ") on %s out of range", > > __func__, val64, ifi->ifi_ifname); > > > > > > -- > Bjoern A. Zeeb r15:7