From owner-svn-src-projects@FreeBSD.ORG Sun Aug 8 13:02:14 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 04945106567A for ; Sun, 8 Aug 2010 13:02:14 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id A793C8FC1A for ; Sun, 8 Aug 2010 13:02:13 +0000 (UTC) Received: by qwg5 with SMTP id 5so5299080qwg.13 for ; Sun, 08 Aug 2010 06:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=jG5A5bjex8+8WDeXelJxt5Vp5/aunlKrySOkWI74Rxw=; b=U0UIGLTcGD9h0KC+mhMeq1kKOrkqLF0qKn+1o64qebkm3E5fHogJyeoSbS6IpQSe7W 8yY3g7Gd4q4J4rFCw450lF+SWHnDrLISPmESZ67b9nUIzkxuBDxwpK6hqvVeMbSG4qdT wjSpTSdjcJfxr7HJWX4R2pHyxu03ghU/XKxEE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=RGBqqb+6rzwx19td1f3Poz01vugdOc4UUXJBgHk+9gB362PtkKQMBcwLnAysim9Mq8 2VeC1Cnfp7czVwHAeljZUbTU6/0FY/WOknFkE3i+rEREvzUtM36cIo2e9EkRra+YyszR Ikr1GQjbYso70H8hSBry9k3Q0O+Bj5U1hqyUY= MIME-Version: 1.0 Received: by 10.224.115.79 with SMTP id h15mr7678705qaq.21.1281270953941; Sun, 08 Aug 2010 05:35:53 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.229.251.6 with HTTP; Sun, 8 Aug 2010 05:35:53 -0700 (PDT) In-Reply-To: <20100808114725.GA34359@sandvine.com> References: <201008071739.o77HdM2Y009458@svn.freebsd.org> <20100808114725.GA34359@sandvine.com> Date: Sun, 8 Aug 2010 14:35:53 +0200 X-Google-Sender-Auth: iMtRxkISzMvU5UdP2Epw3p9lnFA Message-ID: From: Attilio Rao To: Ed Maste Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211029 - projects/sv/sys/net X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2010 13:02:14 -0000 2010/8/8 Ed Maste : > On Sat, Aug 07, 2010 at 05:39:22PM +0000, Attilio Rao wrote: > >> Author: attilio >> Date: Sat Aug =C2=A07 17:39:22 2010 >> New Revision: 211029 >> URL: http://svn.freebsd.org/changeset/base/211029 >> >> Log: >> =C2=A0 Add a tunable for nd_enable. >> =C2=A0 As long as TUNABLE_INT is discouraged, however, switch the type i= nt -> long >> =C2=A0 and adjust accordingly the sysctl stubs. > > This doesn't really make sense as far as I can tell - and particularly > for sysctls, using a long can introduce 32-bit compat issues. =C2=A0I'd > prefer that this remain an int. > > What benefit does using a long provide in this case? Did you see the recent thread on hackers@ about it? If we choice to go with a direction on TUNABLES_* I'd prefer to follow it n= ow. Attilio --=20 Peace can only be achieved by understanding - A. Einstein