From owner-svn-src-all@FreeBSD.ORG Sun Dec 28 06:12:41 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B2331065670; Sun, 28 Dec 2008 06:12:41 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id CC60B8FC17; Sun, 28 Dec 2008 06:12:40 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id mBS6CHia057516; Sat, 27 Dec 2008 23:12:17 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sat, 27 Dec 2008 23:12:29 -0700 (MST) Message-Id: <20081227.231229.139568214.imp@bsdimp.com> To: alfred@freebsd.org From: "M. Warner Losh" In-Reply-To: <20081228053530.GF18389@elvis.mu.org> References: <20081227003826.GV18389@elvis.mu.org> <72A0CF67-F521-4C4B-955D-A80A77CC1165@samsco.org> <20081228053530.GF18389@elvis.mu.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, scottl@samsco.org, src-committers@freebsd.org, mav@freebsd.org Subject: Re: svn commit: r186182 - head/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2008 06:12:41 -0000 In message: <20081228053530.GF18389@elvis.mu.org> Alfred Perlstein writes: : * Scott Long [081226 18:34] wrote: : > : > On Dec 26, 2008, at 5:38 PM, Alfred Perlstein : > wrote: : > > : > >Easy enough to stash a "once" varible in the generic device struct : > >and warn when returning from an isr when INVARIANTS or something is : > >turned on. : > > : > >Then you'd only get one warning per device once it happens. : > > : > > : > : > I prefer to do nothing. It's not unsafe or erroneous to access cfg : > registers. But if some kind of message does get added, I insist that : > it drop all pretenses and say, "you're too poor to run freebsd, come : > back when you can afford better hardware.". :) : : Well that could be the result of a driver that has a "bug" that : makes it access cfg space when it does not need to, as what seems : to have just been fixed. I think we need to have better tools to peer into what's going on inside a driver (or other well defined areas of the kernel). Maybe dtrace might be the right way to do this? Warner