From owner-freebsd-hackers@freebsd.org  Tue Dec  8 15:52:14 2015
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14A029D4D98;
 Tue,  8 Dec 2015 15:52:14 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id D31F21C5F;
 Tue,  8 Dec 2015 15:52:13 +0000 (UTC) (envelope-from des@des.no)
Received: from desk.des.no (smtp.des.no [194.63.250.102])
 by smtp.des.no (Postfix) with ESMTP id 045CED20A;
 Tue,  8 Dec 2015 15:52:13 +0000 (UTC)
Received: by desk.des.no (Postfix, from userid 1001)
 id 81C1D482CD; Tue,  8 Dec 2015 16:52:05 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Maxim Sobolev <sobomax@FreeBSD.org>
Cc: freebsd-current@freebsd.org, freebsd-hackers@freebsd.org,
 Kirk McKusick <mckusick@mckusick.com>, kib@freebsd.org
Subject: Re: posix_fallocate(2) && posix_fadvise(2) are somewhat broken
References: <CAH7qZfvV-RepAc6N0UxFi2RBthxrd+qHD-Qh5dc-9v=NFGCy_w@mail.gmail.com>
Date: Tue, 08 Dec 2015 16:52:05 +0100
In-Reply-To: <CAH7qZfvV-RepAc6N0UxFi2RBthxrd+qHD-Qh5dc-9v=NFGCy_w@mail.gmail.com>
 (Maxim Sobolev's message of "Tue, 8 Dec 2015 01:35:31 -0800")
Message-ID: <868u55rl96.fsf@desk.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Dec 2015 15:52:14 -0000

Maxim Sobolev <sobomax@FreeBSD.org> writes:
> Hi, while working on some unrelated feature I've noticed that at least
> those two system calls are not returning proper value (-1) on error.
> Instead actual errno value is returned from the syscall verbatim,
> i.e. posix_fadvise() returns 22 on EINVAL.

That's how syscalls work.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no