From nobody Fri Jul 8 06:58:28 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EDB8F17D35A4 for ; Fri, 8 Jul 2022 06:58:34 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4LfPJ957Qcz3jyg for ; Fri, 8 Jul 2022 06:58:33 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from sslproxy01.your-server.de ([78.46.139.224]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o9hwb-000Mw9-Tx; Fri, 08 Jul 2022 08:58:30 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9hwc-000Dyp-3N; Fri, 08 Jul 2022 08:58:30 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id C1203480040; Fri, 8 Jul 2022 08:58:29 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id jNBA1lN3Tl0E; Fri, 8 Jul 2022 08:58:29 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 5CB3748016F; Fri, 8 Jul 2022 08:58:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 99_xpCVyinkB; Fri, 8 Jul 2022 08:58:29 +0200 (CEST) Received: from [192.168.96.159] (unknown [192.168.96.159]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 3B402480040; Fri, 8 Jul 2022 08:58:29 +0200 (CEST) Message-ID: <5efeedf3-51dc-e186-48a4-c3dd14b7712e@embedded-brains.de> Date: Fri, 8 Jul 2022 08:58:28 +0200 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 0/6] Simplify pps_capture() and pps_event() Content-Language: en-US To: Warner Losh Cc: FreeBSD Hackers References: <20220707152506.55626-1-sebastian.huber@embedded-brains.de> From: Sebastian Huber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.6/26596/Thu Jul 7 09:53:54 2022) X-Rspamd-Queue-Id: 4LfPJ957Qcz3jyg X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sebastian.huber@embedded-brains.de designates 85.10.215.148 as permitted sender) smtp.mailfrom=sebastian.huber@embedded-brains.de X-Spamd-Result: default: False [-1.40 / 15.00]; NEURAL_HAM_SHORT(-1.00)[-0.999]; R_SPF_ALLOW(-0.20)[+ip4:85.10.215.148]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[78.46.139.224:received]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-hackers]; ASN(0.00)[asn:24940, ipnet:85.10.192.0/18, country:DE]; R_DKIM_NA(0.00)[]; RCVD_COUNT_SEVEN(0.00)[8]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_X_AS(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DMARC_NA(0.00)[embedded-brains.de]; RCVD_TLS_LAST(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 07.07.22 17:52, Warner Losh wrote: > You might have better luck getting these patches reviewed with either a= =20 > pull request against github > mentioning the usual time people (phk, etc), or as a series=C2=A0of=20 > phabricator reviews adding said people. > If unsure, mention/add me and I'll add others :). Thanks for the hint. I opened a Github pull request: https://github.com/freebsd/freebsd-src/pull/604 >=20 > Hackers is (or has been) a high enough volume list that this may not be= =20 > noticed by those people, > especially since there's not a strong tradition of reviewing patches he= re. >=20 > On their surface (without having had time to study them in depth), thes= e=20 > seem reasonable improvements. > But having some context about why you are making these, and/or=20 > measurements you've done to show no > harm (or hopefully an improvement) would be even better. This is=20 > slightly tricky code that has had about 20 > years of "soak time" in some fairly demanding environments, and so some= =20 > caution is advised in updating > it. I don't use FreeBSD directly. I use the FreeBSD timecounters in RTEMS.=20 We recently enabled the PPS_SYNC support and would like to use it for=20 the time synchronization on a spacecraft. For this we have to do a=20 specification and validation tests. This work increases with every "if"=20 in the code. I didn't test the patch on a real system so far (in fact,=20 patch 6 has a typo which was detected by the CI runner). We will=20 definitely do extensive testing when the hardware is available. --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/