From owner-freebsd-current@FreeBSD.ORG  Thu Mar  8 19:26:27 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 123E6106564A;
	Thu,  8 Mar 2012 19:26:27 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id D734D8FC0C;
	Thu,  8 Mar 2012 19:26:26 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
	by cyrus.watson.org (Postfix) with ESMTPSA id 783BC46B0A;
	Thu,  8 Mar 2012 14:26:26 -0500 (EST)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 06897B93B;
	Thu,  8 Mar 2012 14:26:26 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Date: Thu, 8 Mar 2012 10:43:44 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; )
References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org>
	<201203072017.44409.bschmidt@freebsd.org>
	<CAJ-Vmo=T4Muzsgafhfq2QLencWdr37-frpQeczn_U4wx5MhwxA@mail.gmail.com>
In-Reply-To: <CAJ-Vmo=T4Muzsgafhfq2QLencWdr37-frpQeczn_U4wx5MhwxA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201203081043.44801.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Thu, 08 Mar 2012 14:26:26 -0500 (EST)
Cc: Adrian Chadd <adrian@freebsd.org>, freebsd-wireless@freebsd.org,
	Bernhard Schmidt <bschmidt@freebsd.org>
Subject: Re: patches for if_iwi and wlan for WEP mode
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Mar 2012 19:26:27 -0000

On Wednesday, March 07, 2012 2:43:52 pm Adrian Chadd wrote:
> On 7 March 2012 11:17, Bernhard Schmidt <bschmidt@freebsd.org> wrote:
> > On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote:
> >> .. except that the default if_transmit handling breaks fragments. Sigh.
> >>
> >> So we're going to have to implement if_transmit for all net80211
> >> drivers soon and fix fragment handling.
> >
> > Not saying that you are wrong, it is unrelated to the issue at hand
> > though and I'm not even sure it can be fixed just by replacing
> > if_transmit(). Anyways, a bug going unnoticed for 3 years or something
> > isn't that high on my priority list.
> 
> Oh, it's absolutely not a requirement here. It was more a comment that
> he didn't need to implement if_transmit just yet in order to fix this
> bug, but it's likely a good idea moving forward.
> 
> I have recently acquired an iwi(4) NIC so I'll also test this out.
> Don't let me stop you though. :)

However, you could do that by having a net80211_ifattach() type thing that 
sets if_transmit and invokes the driver-provided if_start.  I don't think 
wireless devices are using multiple transmit queues in such a way that 
if_transmit would be a benefit, and if_start is a simpler model.

-- 
John Baldwin