Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Oct 2012 21:38:39 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Cy Schubert <Cy.Schubert@komquats.com>
Cc:        svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: svn commit: r306231 - head/x11-toolkits/xview-clients
Message-ID:  <20121022193839.GC38813@ithaqua.etoilebsd.net>
In-Reply-To: <201210221300.q9MD0L4C003572@slippy.cwsent.com>
References:  <bapt@FreeBSD.org> <201210211216.q9LCGtYf072087@svn.freebsd.org> <201210221300.q9MD0L4C003572@slippy.cwsent.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--E13BgyNx05feLLmH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 22, 2012 at 06:00:21AM -0700, Cy Schubert wrote:
> In message <201210211216.q9LCGtYf072087@svn.freebsd.org>, Baptiste=20
> Daroussin wr
> ites:
> > Author: bapt
> > Date: Sun Oct 21 12:16:55 2012
> > New Revision: 306231
> > URL: http://svn.freebsd.org/changeset/ports/306231
> >=20
> > Log:
> >   Fix build dependency line
> >  =20
> >   Feature safe:	yes
> >=20
> > Modified:
> >   head/x11-toolkits/xview-clients/Makefile
> >=20
> > Modified: head/x11-toolkits/xview-clients/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> > =3D
> > --- head/x11-toolkits/xview-clients/Makefile	Sun Oct 21 12:12:54 2012
> > 	(r306230)
> > +++ head/x11-toolkits/xview-clients/Makefile	Sun Oct 21 12:16:55 2012
> > 	(r306231)
> > @@ -17,7 +17,7 @@ COMMENT=3D	OpenLook applications and man p
> > =20
> >  CONFLICTS=3D	props-1.0
> > =20
> > -PATCH_DEPENDS=3D	${NONEXISTENT}:${.CURDIR}/../xview:patch
> > +PATCH_DEPENDS=3D	${NONEXISTENT}:${PORTSDIR}/x11-toolkits/xview:patch
> >  CONFIGURE_DEPENDS=3D	${NONEXISTENT}:${PORTSDIR}/x11-toolkits/xview:con=
figure
> >  LIB_DEPENDS=3D	xview.3:${PORTSDIR}/x11-toolkits/xview
>=20
> Why? I just rebuilt all my ports about two weeks ago. My massive rebuild=
=20
> didn't need this.
>=20
> Ditto for the previous commit.
>=20
>=20
> --=20
> Cheers,
> Cy Schubert <Cy.Schubert@komquats.com>
> FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org
>=20
> 	The need of the many outweighs the greed of the few.
>=20
>=20

Hi,

It's true that my commit log is not very useful. This change is not to "fix=
" the
ports which were already working but to fix the line to make it consistent =
all
the rest of the ports tree aka
something:${PORTSDIR}/category/port[:target]

The main reason for this is some tools are calling make -VBUILD_DEPENDS
-VRUN_DEPENDS etc to gather all different dependencies in a single call of =
make
(for it to be as fast as possible) both of the tools being for example:
poudriere and portbuild2, but I spotted many other

Given than less then 1% of the ports tree were having "non standard" depend=
ency
line, which were either breaking those tools or which were forcing those to=
ols
to use a slower method to gather the informations and given that the change
wasn't affecting either readability or the way the ports works, I changed t=
he
few ports that were concerned, it was something like around 15 of them over=
 the
24k.

Sorry for not having been informative enough the first time.

regards,
Bapt

--E13BgyNx05feLLmH
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlCFoL8ACgkQ8kTtMUmk6EwoegCcDZJ8ADv4BykIOIVlzoxxqAGw
pEQAoIqjToChOuH9IBgwrUb9FpyMMNeB
=GABT
-----END PGP SIGNATURE-----

--E13BgyNx05feLLmH--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121022193839.GC38813>