Date: Fri, 19 May 2006 09:56:12 +0200 (CEST) From: Harti Brandt <hartmut.brandt@dlr.de> To: Ganbold <ganbold@micom.mng.net> Cc: freebsd-current@freebsd.org, Gleb Smirnoff <glebius@FreeBSD.org> Subject: Re: small patch for ngctl Message-ID: <20060519095344.P13833@beagle.kn.op.dlr.de> In-Reply-To: <446D7741.10102@micom.mng.net> References: <446D7741.10102@micom.mng.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Fri, 19 May 2006, Ganbold wrote: I did not yet look at your patch, but does it work with ngctl receiving unexpected messages? I remember we had something like this in the tree already, but it was backed out, because readline (or libedit, don't remember which one) waiting for input blocked receiving control messages, as far as I remember. harti G>I've made a small patch enhancement for ngctl to support commands history via G>up/down keys when ngctl works under interactive mode. G>It was tested on 7.0-CURRENT machine (FreeBSD 7.0-CURRENT #3: Tue May 16 G>19:17:48 ULAST 2006). G> G>I thought this feature might be useful for all. I hope my patch follows G>style(9) and it is made against CURRENT, it should also cleanly apply on G>RELENG_6. G> G>I saw a similar enhancement patch in PR G>http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/87352 which adds line edit and G>history support to ngctl(8) via libedit. G> G>My patch uses TERMIOS(4) structure which I thought more portable. Maybe I'm G>wrong. G> G>Please let me know if there is anything that I did wrong. G> G>thanks, G> G>Ganbold G> G> G>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060519095344.P13833>