From owner-cvs-all Mon Feb 3 13:50:48 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10A9C37B401; Mon, 3 Feb 2003 13:50:47 -0800 (PST) Received: from ns1.gnf.org (ns1.gnf.org [63.196.132.67]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38FF343F79; Mon, 3 Feb 2003 13:50:46 -0800 (PST) (envelope-from gtetlow@gnf.org) Received: from EXCHCLUSTER01.lj.gnf.org (exch01.lj.gnf.org [172.25.10.19]) by ns1.gnf.org (8.12.3/8.12.3) with ESMTP id h13LoiMf058144; Mon, 3 Feb 2003 13:50:44 -0800 (PST) (envelope-from gtetlow@gnf.org) Received: from roark.gnf.org ([172.25.24.15]) by EXCHCLUSTER01.lj.gnf.org with Microsoft SMTPSVC(5.0.2195.5329); Mon, 3 Feb 2003 13:50:45 -0800 Received: from roark.gnf.org (localhost [127.0.0.1]) by roark.gnf.org (8.12.6/8.12.6) with ESMTP id h13LojGj089962; Mon, 3 Feb 2003 13:50:45 -0800 (PST) (envelope-from gtetlow@gnf.org) Received: (from gtetlow@localhost) by roark.gnf.org (8.12.6/8.12.6/Submit) id h13Lojqr089961; Mon, 3 Feb 2003 13:50:45 -0800 (PST) Date: Mon, 3 Feb 2003 13:50:45 -0800 From: Gordon Tetlow To: Juli Mallett Cc: Dag-Erling Smorgrav , phk@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom_vol_ffs.c Message-ID: <20030203215045.GJ98559@roark.gnf.org> References: <11633.1044300113@critter.freebsd.dk> <20030203201026.GD98559@roark.gnf.org> <20030203134932.A44770@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PEkEgRdBLZYkpbX2" Content-Disposition: inline In-Reply-To: <20030203134932.A44770@FreeBSD.org> User-Agent: Mutt/1.4i X-OriginalArrivalTime: 03 Feb 2003 21:50:45.0965 (UTC) FILETIME=[4E72E7D0:01C2CBCE] Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --PEkEgRdBLZYkpbX2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 03, 2003 at 01:49:32PM -0800, Juli Mallett wrote: > * De: Gordon Tetlow [ Data: 2003-02-03 ] > [ Subjecte: Re: cvs commit: src/sys/geom geom_vol_ffs.c ] > > > - Although tunefs(8) won't let you set a volume label containing > > > anything but alphanumerics (IMHO, it should accept underscores as > > > well), there's nothing in g_vol_ffs_taste() that checks for invalid > > > characters in the label. What happens if I manually edit the > > > superblock and put a / in there? (imagine inserting a borrowed Zip > > > disk and boom...) > >=20 > > I've got a commit in my tree that adds a comment about this. It's on > > my TODO list. I was thinking of adding . as a valid character as well > > (but disallowing leading periods for security reasons). >=20 > Security reasons? What's wrong with things like ls hiding certain > volumes in /dev/vol/ if they aren't using -a or similar? I was thinking more along the lines of .. -gordon --PEkEgRdBLZYkpbX2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+PuQ1Ru2t9DV9ZfsRAvwKAJ9AWiq4CbBg3mi7Sp2jdKISgYKrmACePKft cTtojSTEqqqtLGxGUPDK4L0= =ybrj -----END PGP SIGNATURE----- --PEkEgRdBLZYkpbX2-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message