Date: Tue, 25 Mar 2008 10:06:18 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Pav Lucistnik <pav@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, Alejandro Pulver <alepulver@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/alienarena Makefile distinfo pkg-descr pkg-message ports/games/alienarena/files alienarena-ded.in alienarena-sdl.in alienarena.in patch-Makefile patch-client__menu.c patch-game__acesrc__acebot.h patch-game__acesrc__acebot_nodes.c ... Message-ID: <20080325100618.GB16355@FreeBSD.org> In-Reply-To: <1206439241.71921.9.camel@pav.hide.vol.cz> References: <200803242042.m2OKgSmG034282@repoman.freebsd.org> <20080325095905.GA16355@FreeBSD.org> <1206439241.71921.9.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 25, 2008 at 11:00:41AM +0100, Pav Lucistnik wrote: > Alexey Dokuchaev p??e v ?t 25. 03. 2008 v 09:59 +0000: > > On Mon, Mar 24, 2008 at 08:42:28PM +0000, Alejandro Pulver wrote: > > > Log: > > > Both data and program: > > > - Update to version 2008. > > > > > > Only for games/alienarena: > > > - Remove local patches (now integrated upstream). > > > - Check for WITH_* instead of !WITHOUT_* (avoid double negation). > > > > I've been under impression that common practice is to check for WITH_FOO > > with knobs that are default to off, and !WITHOUT_FOO that default to on. > > No longer needed with OPTIONS. Technically I would agree, but it breaks traditional convention and consistency for little reason. Doing it the old way also aids in reading the Makefile, in a certain way. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080325100618.GB16355>