From owner-freebsd-rc@FreeBSD.ORG Sun May 31 18:34:28 2009 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B0853106564A for ; Sun, 31 May 2009 18:34:28 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 4A95D8FC16 for ; Sun, 31 May 2009 18:34:28 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 877 invoked by uid 399); 31 May 2009 18:34:25 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 31 May 2009 18:34:25 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4A22CDAF.6050506@FreeBSD.org> Date: Sun, 31 May 2009 11:34:23 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.21 (X11/20090423) MIME-Version: 1.0 To: Rick Macklem References: <200905311821.OAA47980@snowhite.cis.uoguelph.ca> In-Reply-To: <200905311821.OAA47980@snowhite.cis.uoguelph.ca> X-Enigmail-Version: 0.95.7 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: rwatson@FreeBSD.org, rc@FreeBSD.org, kib@FreeBSD.org Subject: Re: rc scripts for the new experimental nfs subsystem X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 May 2009 18:34:29 -0000 Rick Macklem wrote: > [good stuff snipped] >> It sounds like what you really want to do is have nfsd REQUIRE nfsuserd. >> >> I'll only comment on a few things, the rest looks good. > > Thanks a lot for the review. I've used your version of nfsd, which I think > is more readable and moved the sig_stop lines up like you suggested. I've > added nfsuserd to the REQUIRE: line in nfsd and also in nfscbd. Looks good to me. Thanks for taking the time to get this right before committing it. :) Doug -- This .signature sanitized for your protection