From owner-freebsd-current@FreeBSD.ORG Wed May 24 20:24:46 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA87116A868 for ; Wed, 24 May 2006 20:24:46 +0000 (UTC) (envelope-from gbergling@0xfce3.net) Received: from einhorn.in-berlin.de (einhorn.in-berlin.de [192.109.42.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id F214343D46 for ; Wed, 24 May 2006 20:24:45 +0000 (GMT) (envelope-from gbergling@0xfce3.net) X-Envelope-From: gbergling@0xfce3.net Received: from central.0xfce3.net (dslb-088-072-036-161.pools.arcor-ip.net [88.72.36.161]) (authenticated bits=128) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id k4OKOgb3006264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 May 2006 22:24:43 +0200 Received: from central.0xfce3.net (localhost [127.0.0.1]) by central.0xfce3.net (8.13.6/8.13.4) with ESMTP id k4OKOgh3059932; Wed, 24 May 2006 22:24:42 +0200 (CEST) (envelope-from gbergling@0xfce3.net) Received: (from gordon@localhost) by central.0xfce3.net (8.13.6/8.13.4/Submit) id k4OKOdPk059931; Wed, 24 May 2006 22:24:39 +0200 (CEST) (envelope-from gbergling@0xfce3.net) X-Authentication-Warning: central.0xfce3.net: gordon set sender to gbergling@0xfce3.net using -f Date: Wed, 24 May 2006 22:24:39 +0200 From: Gordon Bergling To: Scott Long Message-ID: <20060524202439.GA59801@central.0xfce3.net> References: <20060524180802.GA59176@central.0xfce3.net> <4474B908.80903@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4474B908.80903@samsco.org> X-Url: X-Operating-System: FreeBSD 6.1-STABLE i386 X-Host-Uptime: 10:13PM up 7:25, 0 users, load averages: 0.24, 0.11, 0.05 User-Agent: Mutt/1.5.11 X-Spam-Score: * (1.186) AWL,BAYES_50,FORGED_RCVD_HELO X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 Cc: freebsd-current@freebsd.org Subject: Re: Take 2: new IP Checksum Code from DragonFlyBSD X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2006 20:24:48 -0000 Hi Scott, * Thus spake Scott Long (scottl@samsco.org): > Gordon Bergling wrote: > >a few month ago I ported DragonFlyBSD's IP checksum code to FreeBSD. > >My first try wasn't complete and I had forgotten it by the time. Now I > >hope I have addressed the former mistakes and it maybe included in the > >tree. ;) > > > >The patch can be found at > >http://generic.0xfce3.net/20060524-ipchecksum.patch > > > >This patch modifies the i386, amd64 and pc98 architectures. Matt Dillons > >new implementation is machine indepement, but there are some asm > >files/code with seems for me i386 centric. I don't know assembler, so I > >can't tell much about it. > > > >I applied the patch to RELENG_6 and have done a simple netperf > >benchmark. The machine was a PIII 900. > > > >The ministat output: > >---------------------------------------------------------------------------- > >x netperf-localhost-plain.txt > >+ netperf-localhost-ncksum.txt > >+--------------------------------------------------------------------------+ > >| x x x x + ++ + > >| > >|xx x x xx xxx x x x x+x *+x x + +++ ++ + + + +++++ > >+| > >| |__________M_A____________| |__________A___________| > >| > >+--------------------------------------------------------------------------+ > > N Min Max Median Avg Stddev > >x 22 707.31 730.41 717.37 718.53909 6.7389076 > >+ 22 725.57 746.46 736.535 736.51727 6.3001188 > >Difference at 95.0% confidence > > 17.9782 +/- 3.96904 > > 2.50205% +/- 0.552377% > > (Student's t, pooled s = 6.5232) > >---------------------------------------------------------------------------- > > > >Any comments, correctures are very appreciated. > > > >best regards, > > > > Gordon > > > > First, it would be nice to know what netstat options you were using. > Second, it would be nice to know if hardware checksum offloading was > enabled at all on either end of the test. I don't know what do you mean with netstat options. If you mean the benchmark, that was the following procedure. 1. /usr/local/netperf/netserver 2. for i in 0 1 2 3 4 5 6 7 8 9 do /usr/local/netperf/netperf -P 0 >> ~/netperf-xyz.txt done Step 2 was done twice. I cutted the 'Throughput' fields out of the netperf-xyz.txt, for use with ministat. The nic I had used is a simple | fxp0: port ... I havn't enabled any hardware checksum offloading as far as I know. Please let me know, if there are other questions left... best regards, Gordon -- Gordon Bergling http://www.0xFCE3.net/ PGP Fingerprint: 7732 9BB1 5013 AE8B E42C 28E0 93B9 D32B C76F 02A0 RIPE-HDL: MDTP-RIPE "Minimal Electronic Music"