From owner-freebsd-current@freebsd.org Mon Oct 21 08:10:15 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EC370177ABA for ; Mon, 21 Oct 2019 08:10:15 +0000 (UTC) (envelope-from zeising+freebsd@daemonic.se) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46xTpH2PsLz3Qjb for ; Mon, 21 Oct 2019 08:10:15 +0000 (UTC) (envelope-from zeising+freebsd@daemonic.se) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 46xTpG0m82z3lKv; Mon, 21 Oct 2019 08:10:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=daemonic.se; h= content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:subject:subject:received :received; s=20151023; t=1571645413; bh=jcBeFsA1lhv87pizWRXt2rG3 uYXhe4KJTb5P2KSncPg=; b=EITMGLUCB2p0SLbMKNMEc2Vu+6tTLWKu2b4xcmDC WkmgU+lxys4HVIuwAsmDEGWzDaJsCsWFnfYvq5KlVxQ6CZ2j789ir4+YE+NiWqSR Gqo918KMKk1bMRfyITNdyNeqMi5BcroayXGhAqPBk7MrMF3s6JfI01PzqzLAiTM7 QWc= X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id 9JlgK0xt9IHc; Mon, 21 Oct 2019 08:10:13 +0000 (UTC) Received: from garnet.daemonic.se (host-95-192-35-193.mobileonline.telia.com [95.192.35.193]) by mail.daemonic.se (Postfix) with ESMTPSA id 46xTpD4Ryjz3lKt; Mon, 21 Oct 2019 08:10:12 +0000 (UTC) Subject: Re: DRM-current-kmod is still a problem at r353339 To: Thomas Mueller , freebsd-current@freebsd.org References: <7ca3b30a-81f6-f79d-1486-7fd29765646f@acm.org> <99c89ca0-462c-f4c7-fa07-6f61e9d39d66@acm.org> <3bb2e410-51dd-bc3f-7660-41a4683551b3@daemonic.se> <20191017195347.GB6447@raichu> <53ff1ac5-c7e8-1b6c-bd43-481eaef61120@daemonic.se> <72d67f0a-aeef-1c06-2b12-9351a1f52060@anduin.net> <689d53378dcca22adb29aa23f03e8e1b@neelc.org> <25593555-6452-0933-d0fe-0459425cde55@delphij.net> <7cb6ecd6-2dcd-92e4-75a3-5e5d34377ed6@yuripv.net> From: Niclas Zeising Message-ID: Date: Mon, 21 Oct 2019 10:10:12 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46xTpH2PsLz3Qjb X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=daemonic.se header.s=20151023 header.b=EITMGLUC; dmarc=pass (policy=none) header.from=daemonic.se; spf=pass (mx1.freebsd.org: domain of zeising@daemonic.se designates 2607:f740:d:20::25 as permitted sender) smtp.mailfrom=zeising@daemonic.se X-Spamd-Result: default: False [-6.71 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[daemonic.se:s=20151023]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-3.71)[ip: (-9.75), ipnet: 2607:f740:d::/48(-4.87), asn: 36236(-3.85), country: US(-0.05)]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[daemonic.se:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[daemonic.se,none]; FREEMAIL_TO(0.00)[twc.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:36236, ipnet:2607:f740:d::/48, country:US]; TAGGED_FROM(0.00)[freebsd]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[193.35.192.95.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Oct 2019 08:10:16 -0000 On 2019-10-21 09:01, Thomas Mueller wrote: > from Neel Chauhan: > >> For me, the following code is still necessary for me (HP Spectre x360 >> 2018), which is the remaining parts of the patches not committed if you >> are using a recent kernel. I don't know about you all ThinkPad users, it >> should still apply as it's Intel in general not just HP or Lenovo. >> Without these patches, I get a kernel panic. > >> Keep in mind that the patch may render as spaces, but it should be tabs. > > What happens if the patch is applied with spaces as opposed to tabs? > > I believe, in C, there is no difference as far as compiling is concerned. > > Or is it just a standard for formatting? > If the whitespace isn't correct, the patch won't apply cleanly. It has no effect on compiling the code though. Regards -- Niclas