Date: Sun, 14 Jan 2018 13:16:57 -0700 From: Warner Losh <imp@bsdimp.com> To: Mark Johnston <markj@freebsd.org> Cc: Pedro Giffuni <pfg@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327949 - in head/sys/dev: aacraid advansys ath beri/virtio bnxt bwn ciss cxgbe/crypto esp fb gpio if_ndis iwi kbd liquidio liquidio/base mpr mps mpt mrsas mxge netmap nvme pst ral rp s... Message-ID: <CANCZdfo%2BpkT7pSnqvbwjJrD8KP_MyQgHDbtu%2B9qaedj_J0qVMw@mail.gmail.com> In-Reply-To: <20180114171448.GB89171@raichu> References: <201801132230.w0DMUVmF081985@repo.freebsd.org> <7fe2a0bb-8592-75bc-6f58-cb77e2d6044c@FreeBSD.org> <20180114171448.GB89171@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 14, 2018 10:15 AM, "Mark Johnston" <markj@freebsd.org> wrote: On Sat, Jan 13, 2018 at 05:34:24PM -0500, Pedro Giffuni wrote: > > > On 01/13/18 17:30, Pedro F. Giffuni wrote: > > Author: pfg > > Date: Sat Jan 13 22:30:30 2018 > > New Revision: 327949 > > URL: https://svnweb.freebsd.org/changeset/base/327949 > > > > Log: > > dev: make some use of mallocarray(9). > > > > Focus on code where we are doing multiplications within malloc(9). None of > > these is likely to overflow, however the change is still useful as some > > static checkers can benefit from the allocation attributes we use for > > mallocarray. > > > > This initial sweep only covers malloc(9) calls with M_NOWAIT. No good > > reason but I started doing the changes before r327796 and at that time it > > was convenient to make sure the sorrounding code could handle NULL values. > > > For the record, this was part of > > https://reviews.freebsd.org/D13837 > > I didn't mention it in the commit log because I am not ready to close > the revision yet. Some developers have been using the "X-Differential revision:" tag in this case. I just list it per normal, but reopen the review if I need to. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo%2BpkT7pSnqvbwjJrD8KP_MyQgHDbtu%2B9qaedj_J0qVMw>